[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

This revision was automatically updated to reflect the committed changes. Closed by commit rGab5823867c4a: [analyzer] Find better description for tracked symbolic values (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/n

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

NoQ accepted this revision. NoQ added a comment. Awesome, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340499. vsavchenko marked an inline comment as done. vsavchenko added a comment. Limit the number of cases where the new note refinement takes place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

steakhal added a comment. This is an improvement! Good job. I had no time reviewing this, but I think it's already in a pretty good shape. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 _

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko marked 4 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. + StoreManage

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340473. vsavchenko added a comment. Refactor the way we get Region for variable declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 Files: clang/lib/Stat

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong accepted this revision. martong added a comment. This revision is now accepted and ready to land. For me it looks good now. The changes, however, seem to be unrelated to retain count checker. Do you think it would make sense to upstream this patch independently from the other 3 patches

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 340469. vsavchenko added a comment. Add one more testg covering the situation when we can't pick up that one region to associate with the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ htt

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:163-165 + ProgramStateManager &StateMgr = N->getState()->getStateManager(); + MemRegionManager &MRMgr = StateMgr.getRegionManager(); + return MRMgr.getVarRegion(VD, N->getL

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. + StoreManager::FindUniqueBinding FB(V.getAsLocSymbol());

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1532 + // Telling the user that the value of 'a' is assigned to 'c', while + // correct, can be confusing. + StoreManager::FindUniqueBinding FB(V.getAsLocSymbol()); ---

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1529 + // b = a; + // c = foo(b); + // martong wrote: > I'd rather use `identity` here (and at line 1509) instead of `foo`, I think > that

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

martong added a comment. Awesome! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1529 + // b = a; + // c = foo(b); + // I'd rather use `identity` here (and at line 1509) instead of `foo`, I think that could make this e

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko updated this revision to Diff 339578. vsavchenko added a comment. Minor fix in comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101041/new/ https://reviews.llvm.org/D101041 Files: clang/lib/StaticAnalyzer/Core/BugReporterVisitor

[PATCH] D101041: [analyzer] Find better description for tracked symbolic values

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald