[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77e170db8678: [ARM][Driver][Windows] Allow command-line upgrade to Armv8. (authored by simon_tatham). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham updated this revision to Diff 339161. simon_tatham added a comment. Added a unit test on the LLVM side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 Files: clang/test/Driver/woa-crypto.c

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo added a comment. In D100937#2704530 , @simon_tatham wrote: > Yes, it looks easy enough to add something in > `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. > > I'd mildly prefer to do that //as well// as having the tes

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham added a comment. Yes, it looks easy enough to add something in `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. I'd mildly prefer to do that //as well// as having the test here, because the call site in the clang driver is quite complicated. My real aim is t

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Driver/woa-crypto.c:2 +// RUN: %clang -target arm-windows-msvc -### -S %s -O0 -o /dev/null 2>&1 | FileCheck %s

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

simon_tatham created this revision. simon_tatham added reviewers: mstorsjo, thakis. Herald added subscribers: dexonsmith, danielkiss, hiraditya, kristof.beyls. simon_tatham requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. I