[PATCH] D100852: [analyzer] Track leaking object through stores

This revision was automatically updated to reflect the committed changes. Closed by commit rGe273918038a7: [analyzer] Track leaking object through stores (authored by vsavchenko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/ https://rev

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ accepted this revision. NoQ added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountDiagnostics.cpp:636 if (isa(R)) - Result.push_back(R); + Result.emplace_back(R, Val)

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko added a comment. In D100852#2704282 , @NoQ wrote: > I think this is already way better than before. I see that `OSDynamicCast` > isn't supported yet and we seem to hit the same wall as D97183 > because inter-

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko updated this revision to Diff 339143. vsavchenko marked an inline comment as done. vsavchenko added a comment. Add a comment and replace getAs with castAs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100852/new/ https://reviews.llvm.org

[PATCH] D100852: [analyzer] Track leaking object through stores

NoQ added a comment. I think this is already way better than before. I see that `OSDynamicCast` isn't supported yet and we seem to hit the same wall as D97183 because inter-operation between `trackExpressionValue` and the checkers isn't implemented yet.

[PATCH] D100852: [analyzer] Track leaking object through stores

vsavchenko created this revision. vsavchenko added reviewers: NoQ, martong, steakhal, xazax.hun. Herald added subscribers: ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. vsavchenko requested review of this revision. Herald