This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
HsiangKai marked an inline comment as done.
Closed by commit rG14cc1cb22230: [RISCV] Implement the vneg.v builtin.
(authored by HsiangKai).
Changed prior to commit:
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100819/new/
https://reviews.llvm.org/D100819
___
HsiangKai marked 3 inline comments as done.
HsiangKai added inline comments.
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048
+ return Cmp < 0;
+ // Some mask intrinsics use the same IRName as unmasked.
+ // Sor
HsiangKai updated this revision to Diff 339452.
HsiangKai added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100819/new/
https://reviews.llvm.org/D100819
Files:
clang/include/clang/Basic/riscv_vector.td
clang/test
craig.topper added inline comments.
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048
+ return Cmp < 0;
+ // Some mask intrinsics use the same IRName as unmasked.
+ // Sort the unmasked intrinsics first.
khchen added inline comments.
Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vneg.c:3
+// REQUIRES: riscv-registered-target
+// RUN: %clang_cc1 -triple riscv32 -target-feature +f -target-feature +d
-target-feature +experimental-v \
+// RUN: -target-feature +exp
frasercrmck added inline comments.
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1048
+ return Cmp < 0;
+ // Some mask intrinsics use the same IRName as unmasked.
+ // Sort the unmasked intrinsics first.
-
HsiangKai created this revision.
HsiangKai added reviewers: craig.topper, khchen, frasercrmck.
Herald added subscribers: StephenFan, vkmr, dexonsmith, evandro, luismarques,
apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck, rogfer01, edward-jon