This revision was automatically updated to reflect the committed changes.
Closed by commit rG26f138eed4af: [Debug-Info] implement -gstrict-dwarf
(authored by shchenz).
Changed prior to commit:
https://reviews.llvm.org/D100809?vs=338752&id=339464#toc
Repository:
rG LLVM Github Monorepo
CHANG
shchenz added a comment.
Thanks for your review! @probinson @dblaikie @aprantl
Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550
+Use DWARF extensions in later DWARF versions.
+
.. option:: -gz=, -gz (equivalent to -gz=zlib)
probinson wrote:
> d
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Sounds good
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100809/new/
https://reviews.llvm.org/D100809
probinson added a comment.
Nit on the description, this patch supports -gstrict-dwarf in the frontend.
Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550
+Use DWARF extensions in later DWARF versions.
+
.. option:: -gz=, -gz (equivalent to -gz=zlib)
-
dblaikie added inline comments.
Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550
+Use DWARF extensions in later DWARF versions.
+
.. option:: -gz=, -gz (equivalent to -gz=zlib)
This description is probably backwards/doesn't explicitly clarify whi
shchenz updated this revision to Diff 338752.
shchenz marked 2 inline comments as done.
shchenz added a comment.
address @dblaikie comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100809/new/
https://reviews.llvm.org/D100809
Files:
clang/
shchenz added inline comments.
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3973-3974
+ // as true by default.
+ if (const Arg *A = Args.getLastArg(options::OPT_gstrict_dwarf))
+(void)checkDebugInfoOption(A, Args, D, TC);
+ if (Args.hasFlag(options::OPT_gstrict_dwarf,
shchenz created this revision.
shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo,
PowerPC.
shchenz added a project: debug-info.
Herald added subscribers: jansvoboda11, dexonsmith, dang.
shchenz requested review of this revision.
Herald added a project: clang.
Herald added
