[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2a030e680e08: [clangd][ObjC] Fix issue completing a method decl by name (authored by dgoldman). Repositor

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:160 + // + // e.g. to complete `- (void)doSomething:(id)argument`: + // - Completion name: `doSomething:` -

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 349014. dgoldman added a comment. Add another test for a simple method decl (no arg selector) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files: clang-tools-ex

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks for the detailed comments, this makes a lot more sense to me now! Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:160 + // + //

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:152 // // TODO: Make previous parameters part of the signature for Objective-C // methods. sammccall wrote: > is this TODO handled now? No, t

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 340619. dgoldman marked 4 inline comments as done. dgoldman added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files: clang-t

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

sammccall added a comment. Herald added a subscriber: cfe-commits. The test results look good, but I have trouble following the code, I think more comments might help :-) Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:140 + // similar except that we use