[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rupprecht added a comment. Landed 44e2247dcd04f3421164b085094eb575270564ba to fix LLDB. If you decide to go in a different direction again, please adjust that fix accordingly. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0f1137ba79c0: [clang/Basic] Make TargetInfo.h not use DataLayout again (authored by thakis). Herald added a project: clang. Changed prior to commit:

Re: [PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

Sounds good. It's a soft objection, mostly because if nothing else it puts us back where we were subject to some latent bugs, but perhaps not as bad as before (though I don't find having to use an assert build reassuring ;) Anyhow, go ahead and we'll figure out something else. On Tue, Apr 27, 202

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D100776#2703273 , @echristo wrote: > As is mentioned there are tradeoffs around this though: a) it does make it > harder to have clang generate code with

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100776/new/ https://reviews.llvm.org/D100776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. rnk, echristo: can we go ahead here? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100776/new/ https://reviews.llvm.org/D100776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. > This keeps the assert that checks that the llvm DataLayout and the user label > prefix are in sync. See the NDEBUG in Mangle.cpp here-ish: > https://reviews.llvm.org/D100776#change-NN4Lz7xH29fo (I measured that that > assert doesn't slow down `check-clang` in a release

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. > So, if this is really causing some consternation then we can pull back and > reinstate what we had, but it was a direction around solving a set of hard to > find bugs. > > Thoughts? This keeps the assert that checks that the llvm DataLayout and the user label prefix a

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

echristo added a comment. In D100776#2699603 , @thakis wrote: > In D100776#2699565 , @rnk wrote: > >> Of the three people who commented on D17183 >> , you and I are on the only on

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis added a comment. In D100776#2699565 , @rnk wrote: > Of the three people who commented on D17183 > , you and I are on the only ones in favor of > this approach. I think @echristo and @jyknight both preferred approa

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

rnk added subscribers: jyknight, echristo. rnk added a comment. Of the three people who commented on D17183 , you and I are on the only ones in favor of this approach. I think @echristo and @jyknight both preferred approach 2. I'd like to get at least an agreemen

[PATCH] D100776: [clang/Basic] Make TargetInfo.h not use DataLayout again

thakis created this revision. thakis added a reviewer: rnk. Herald added subscribers: dexonsmith, kerbowa, kbarton, mgorny, nhaehnle, jvesely, nemanjai. thakis requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Reverts parts of https://review