thakis added a comment.
Purely FYI: the `--` in the test isn't needed just on macOS but also on Linux
if your checkout is eg under /usr: http://45.33.8.238/linux/44652/step_7.txt
(clang-cl has some nice diag if the /U flag is an existing file, since that
happens fairly often. Maybe llvm-rc coul
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG64bc44f5ddfb: [llvm-rc] Run clang to preprocess input files
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D100755?vs=3
aganea accepted this revision.
aganea added a comment.
LGTM.
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94
+
+ErrorOr findClang(const char *Argv0) {
+ StringRef Parent = llvm::sys::path::parent_path(Argv0);
mstorsjo wrote:
> aganea wrote:
> > Since you're not
mstorsjo added inline comments.
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94
+
+ErrorOr findClang(const char *Argv0) {
+ StringRef Parent = llvm::sys::path::parent_path(Argv0);
aganea wrote:
> Since you're not using the `std::error_code` below in the call site,
aganea added inline comments.
Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94
+
+ErrorOr findClang(const char *Argv0) {
+ StringRef Parent = llvm::sys::path::parent_path(Argv0);
Since you're not using the `std::error_code` below in the call site, should
this retu
mstorsjo updated this revision to Diff 338969.
mstorsjo added a comment.
Herald added subscribers: cfe-commits, mgorny.
Herald added a project: clang.
- Added a testcase under clang/test/Preprocessor
- Changed the option to -no-preprocess
- Removed the env var for disabling preprocessing
- Made it
