This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1f8963c80195: [clangd] Parameter hints for dependent calls
(authored by nridge).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
nridge added inline comments.
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264
+// FIXME: This one does not work yet.
+A::static_member($par3[[t]]);
}
sammccall wrote:
> nridge wrote:
> > This is an interesting case. Cl
nridge updated this revision to Diff 342314.
nridge added a comment.
Address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100742/new/
https://reviews.llvm.org/D100742
Files:
clang-tools-extra/clangd/HeuristicResolver.cpp
clang
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/InlayHints.cpp:56
+auto CalleeDecls = Resolver->resolveCalleeOfCallExpr(E);
+if (CalleeDecls.empty())
+ return tru
nridge added a reviewer: sammccall.
nridge added inline comments.
Comment at: clang-tools-extra/clangd/unittests/InlayHintTests.cpp:264
+// FIXME: This one does not work yet.
+A::static_member($par3[[t]]);
}
This is an interesting case. Cla
nridge updated this revision to Diff 340439.
nridge added a comment.
Herald added a subscriber: cfe-commits.
Add some more test cases
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100742/new/
https://reviews.llvm.org/D100742
Files:
clang-tools-e
