xgupta added a comment.
@jnyfah you may close this revision. changes are committed by
https://reviews.llvm.org/rG21bef4e11e48d5d4bff7a23babbd420e86dd420a.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100696/new/
https://reviews.llvm.org/D100696
Meinersbur added inline comments.
Comment at: polly/docs/ReleaseNotes.rst:9
- These release notes are for the next release of Polly and it describes
+ These release notes are for the next release of Polly and describe
the new features that have recently been committed to o
xgupta added a comment.
@jnyfah If you are missing something I am just telling you the steps -
1. First fork the llvm github repository
2. git clone https://github.com/jynfah/llvm-project
3. git checkout -b type-fix
4. make changes to files.
5. git diff > mypatch.patch
6. git commit -m "fix typo
xgupta added a comment.
Actually, I am not able to apply this patch with `arc patch D100696`.
Created and checked out branch arcpatch-D100696.
Checking patch polly/docs/ReleaseNotes.rst...
error: while searching for:
.. warning::
These release notes are for the next release of Polly and it de
xgupta accepted this revision.
xgupta added a comment.
This revision now requires review to proceed.
Oh sorry, Your patch is correct. I misunderstand something :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100696/new/
https://reviews.llvm.org/D1
xgupta requested changes to this revision.
xgupta added a comment.
This revision now requires changes to proceed.
Thanks @jnyfah for the patch!
It looks you need to rebase your branch to llvm upstream main branch. Because
polly/docs/ReleaseNotes.rst is recently change. Now its contain nothing se
curdeius accepted this revision as: curdeius.
curdeius added a comment.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100696/new/
https://reviews.llvm.org/D100696
___
cfe-commits mailing li
jnyfah created this revision.
Herald added a reviewer: bollu.
jnyfah requested review of this revision.
Herald added projects: clang, libc++.
Herald added subscribers: libcxx-commits, cfe-commits.
Herald added a reviewer: libc++.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D100
