[PATCH] D100616: [clang] Fix a potential assert failure

MaskRay added inline comments. Comment at: clang/include/clang/Basic/TargetBuiltins.h:334 static constexpr uint64_t LargestBuiltinID = std::max( {NEON::FirstTSBuiltin, ARM::LastTSBuiltin, SVE::FirstTSBuiltin, AArch64::LastTSBuiltin, BPF::LastTSBuiltin, PPC::Last

[PATCH] D100616: [clang] Fix a potential assert failure

craig.topper added a comment. In D100616#2693607 , @MaskRay wrote: > In D100616#2693603 , @craig.topper > wrote: > >> In D100616#2693595 , @MaskRay >> wrote: >> >>> SVE:

[PATCH] D100616: [clang] Fix a potential assert failure

MaskRay added a comment. In D100616#2693603 , @craig.topper wrote: > In D100616#2693595 , @MaskRay wrote: > >> SVE::FirstTSBuiltin is 8148, the largest. > > Isn't SVE::FirstTSBuiltin used to start AArch64's built

[PATCH] D100616: [clang] Fix a potential assert failure

craig.topper added a comment. In D100616#2693595 , @MaskRay wrote: > SVE::FirstTSBuiltin is 8148, the largest. Isn't SVE::FirstTSBuiltin used to start AArch64's builtins list. So shouldn't AArch64::LastTSBuiltin be larger? Repository: rG LLVM Github

[PATCH] D100616: [clang] Fix a potential assert failure

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. SVE::FirstTSBuiltin is 8148, the largest. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100616/new/ https://reviews.llvm.org/D100616

[PATCH] D100616: [clang] Fix a potential assert failure

benshi001 created this revision. benshi001 added a reviewer: MaskRay. Herald added subscribers: s.egerton, simoncook, dschuff. benshi001 requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a project: clang. The calculation of LargestBuiltinID needs all t