[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-05-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added subscribers: vsk, rnk. rnk added inline comments. Herald added a subscriber: jeroen.dobbelaere. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:5155 +#define BUILTIN(ID, TYPE, ATTRS) case RISCV::BI##ID: +#include "clang/Basic/BuiltinsRISCV.def" +#undef BUILTIN -

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-24 Thread Hsiangkai Wang via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG108864397d26: [Clang] Add clang attribute `clang_builtin_alias`. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D10061

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from a small nit with the documentation wording. Comment at: clang/include/clang/Basic/AttrDocs.td:5704 + +This attribute is deprecated. Use clang_builtin_alias instead. }]; I'd

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 340232. HsiangKai added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/include/clan

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-23 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added inline comments. Comment at: clang/include/clang/Basic/Attr.td:646 +def BuiltinAlias : Attr { + let Spellings = [Clang<"clang_builtin_alias">]; + let Args = [IdentifierArgument<"BuiltinName">]; aaron.ballman wrote: > Hrm, this is interesting --

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-23 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:646 +def BuiltinAlias : Attr { + let Spellings = [Clang<"clang_builtin_alias">]; + let Args = [IdentifierArgument<"BuiltinName">]; Hrm, this is interesting -- this will allow the

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai added a comment. @aaron.ballman, could you help me to review it again? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 ___ cfe-commits mailing

[PATCH] D100611: [Clang] Add clang attribute `clang_builtin_alias`.

2021-04-22 Thread Hsiangkai Wang via Phabricator via cfe-commits
HsiangKai updated this revision to Diff 339606. HsiangKai added a comment. Update test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100611/new/ https://reviews.llvm.org/D100611 Files: clang/include/clang/Basic/Attr.td clang/include/clan