tra added a comment.
Enforcing explicit GPU target makes sense.
However, I think that singling out a `__global__` as the trigger is not
sufficient for the intended purpose.
If we can't generate a usable GPU-side binary, then we should produce an error
if we need to generate *anything* during G
yaxunl updated this revision to Diff 337883.
yaxunl marked an inline comment as done.
yaxunl added a comment.
revised error msg by Aaron's comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100552/new/
https://reviews.llvm.org/D100552
Files:
clang/include/clang/Basic/DiagnosticSe
aaron.ballman added a comment.
Drive-by comment on the diagnostic wording.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8260
+def err_hip_kern_without_gpu : Error<
+ "compile HIP kernel without specifying offload arch is not allowed">,
+ DefaultFatal;
yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kerbowa, tpr, nhaehnle, jvesely.
Herald added a reviewer: aaron.ballman.
yaxunl requested review of this revision.
AMDGPU does not have a common processor (GPU arch). A HIP kernel
must be compiled with a specifie
