This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0a92e09c0785: [clang][deps] Generate the full command-line
for modules (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.o
jansvoboda11 added a comment.
Thanks for the review!
Comment at: clang/include/clang/Frontend/CompilerInstance.h:230
+
+ std::shared_ptr getInvocationPtr() {
assert(Invocation && "Compiler instance has no invocation!");
dexonsmith wrote:
> Is `get*Ptr()`
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM, just a couple of other comments inline.
Comment at: clang/include/clang/Frontend/CompilerInstance.h:230
+
+ std::shared_ptr getInvocationPtr() {
assert(In
jansvoboda11 added inline comments.
Comment at: clang/lib/Tooling/DependencyScanning/ModuleDepCollector.cpp:62
std::function LookupModuleDeps) const {
- // TODO: Build full command line. That also means capturing the original
- // command line into NonPathCommandLine
jansvoboda11 added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:78-80
+ /// The compiler invocation associated with the translation unit that imports
+ /// this module.
+ CompilerInvocation Invocation;
dexon
jansvoboda11 updated this revision to Diff 338069.
jansvoboda11 added a comment.
Share `ModuleDeps::Invocation`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100534/new/
https://reviews.llvm.org/D100534
Files:
clang/include/clang/Frontend/Compil
dexonsmith added inline comments.
Comment at:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:78-80
+ /// The compiler invocation associated with the translation unit that imports
+ /// this module.
+ CompilerInvocation Invocation;
Looks l
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch uses the new `CompilerInvocation::generateCC1CommandLine` to
generate the full
