[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Herald added a subscriber: ormris. Herald added a project: All. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1208 + + *StackUsageStream << MF.getFunction().getParent()->getName(); + if (const DISubprogram *DSP = MF.getFunction().getSubpr

[PATCH] D100509: Support GCC's -fstack-usage flag

This revision was automatically updated to reflect the committed changes. Closed by commit rGc9b36a041fd7: Support GCC's -fstack-usage flag (authored by pzheng). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for all the feedbacks, @MaskRay! I will wait another day before committing the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D1005

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345498. pzheng added a comment. Address new comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/includ

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LG with some nits. After fixes, please wait one day or so in case there are further comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5500 + SmallString<128

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 345470. pzheng added a comment. Address @MaskRay's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + pzheng wrote: > MaskRay wrote: > > CC1 needs two options? > > >

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 2 inline comments as done. pzheng added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when -fstack-us

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 344135. pzheng added a comment. Address a few more comments from @MaskRay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:110 CODEGENOPT(StackSizeSection , 1, 0) ///< Set when -fstack-size-section is enabled. +CODEGENOPT(StackUsage, 1, 0) ///< Set when -fstack-usage is enabled. CODEGENOPT(ForceDwarfFr

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343795. pzheng added a comment. Minor update to some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 7 inline comments as done. pzheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + MaskRay wrote: > CC1 need

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 343794. pzheng added a comment. Addess @MaskRay's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNotes.rst clang/include/clang/B

[PATCH] D100509: Support GCC's -fstack-usage flag

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5474 + if (Args.hasArg(options::OPT_fstack_usage)) { +CmdArgs.push_back(Args.MakeArgString("-fstack-usage")); + CC1 needs two options? If you infer the filename in the driver,

[PATCH] D100509: Support GCC's -fstack-usage flag

jansvoboda11 added a comment. This LGTM from command-line perspective, but I'll let others judge the rest of the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 ___

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 338551. pzheng added a comment. Add missing comments. Thanks for spotting it, @xbolva00. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/ReleaseNot

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. cc @r Comment at: clang/include/clang/Basic/CodeGenOptions.h:391 std::vector SanitizeCoverageBlocklistFiles; + std::string StackUsageOutput; Nit: comment? Like one in TargetOptions.h Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. Thanks for all the great feedbacks, @jansvoboda11, @xbolva00 and @lebedev.ri! Is there any other concern that needs to be addressed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. In D100509#2693388 , @pzheng wrote: > I checked some of the functions in zstd where gcc outputs "dynamic,bounded", > but did not find any straightforward way to simplify them into standalone > tests. If anyone happen to have a

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. I checked some of the functions in zstd where gcc outputs "dynamic,bounded", but did not find any straightforward way to simplify them into standalone tests. If anyone happen to have a simple test case, I would be more than happy to add here. Repository: rG LLVM Gith

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. Great if better :) Please consider adding a small testcase (eg from zstd) where llvm says static and gcc says dynamic,bound. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 ___

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2692259 , @xbolva00 wrote: > Set current_function_has_unbounded_dynamic_stack_size to 1 when pushing a > variable-sized argument onto the stack. > > if (current_function_has_unbounded_dynamic_stack_size) >

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. Set current_function_has_unbounded_dynamic_stack_size to 1 when pushing a variable-sized argument onto the stack. if (current_function_has_unbounded_dynamic_stack_size) stack_usage_kind = DYNAMIC; else stack_usage_kind = DYNAMIC_BOUN

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2692127 , @xbolva00 wrote: >>> :: > > gcc also supports "bounded" - do you plan to somehow handle it? > (https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#Developer-Options), > eg: parser.c:918:5:parse_statem

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. >> :: gcc also supports "bounded" - do you plan to somehow handle it? (https://gcc.gnu.org/onlinedocs/gcc/Developer-Options.html#Developer-Options), eg: parser.c:918:5:parse_statement 48 dynamic,bounded Comment at: clang/test/CodeGen/stack-u

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337802. pzheng added a comment. Mention the flag in release notes based on @xbolva00's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/docs/Rel

[PATCH] D100509: Support GCC's -fstack-usage flag

xbolva00 added a comment. It would be great to also update release notes for clang to inform users about this new feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng marked 3 inline comments as done. pzheng added a comment. Thanks for your feedback, @jansvoboda11! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 ___ cf

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng updated this revision to Diff 337778. pzheng added a comment. Address @jansvoboda11's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D100509 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D100509: Support GCC's -fstack-usage flag

jansvoboda11 added a comment. I left a couple of comments inline on the command-line parsing aspect of the patch. For more info, check https://clang.llvm.org/docs/InternalsManual.html#adding-new-command-line-option. Comment at: clang/include/clang/Driver/Options.td:2658 + Fl

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng added a comment. In D100509#2689839 , @lebedev.ri wrote: > Might you be interested in implementing [[ > https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a > follow-up? Thanks for bring it up, @lebedev.ri. Yes, I will lo

[PATCH] D100509: Support GCC's -fstack-usage flag

lebedev.ri added a comment. Might you be interested in implementing [[ https://bugs.llvm.org/show_bug.cgi?id=44418 | `-Wstack-usage=` ]] diag as a follow-up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100509/new/ https://reviews.llvm.org/D1005

[PATCH] D100509: Support GCC's -fstack-usage flag

pzheng created this revision. pzheng added reviewers: apazos, efriedma, seaneveson, bruno, MatzeB, hfinkel. Herald added subscribers: jansvoboda11, dexonsmith, dang, hiraditya. pzheng requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-