[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

kadircet added a comment. > Hit send too soon. But IIRC PP knows whether it's building a preamble. That's a good point. But PP doesn't know if there's trailing content or not (in clangd's case). So we'll end up not showing the diag even when we should (i.e. whole file is preamble without a new

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

sammccall added a comment. Hit send too soon. But IIRC PP knows whether it's building a preamble. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100501/new/ https://reviews.llvm.org/D100501 ___ cfe-commit

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

sammccall added a comment. A too-late drive-by - maybe we'd be better detecting these in clang never emitting these Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100501/new/ https://reviews.llvm.org/D100501 ___

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa46bbc14f004: [cland] Dont emit missing newline warnings when building preamble (authored by kadircet). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100501: [cland] Dont emit missing newline warnings when building preamble

kadircet updated this revision to Diff 339901. kadircet marked an inline comment as done. kadircet added a comment. Herald added a subscriber: cfe-commits. - Handle cxx98 and extension versions of the warning too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews