rsanthir.quic abandoned this revision.
rsanthir.quic added a comment.
Merging with https://reviews.llvm.org/D100772
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100499/new/
https://reviews.llvm.org/D100499
___
cfe-commits mailing list
cfe-co
rsanthir.quic added a comment.
Here's the fix for enabling these on ARM:
https://reviews.llvm.org/D100772
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100499/new/
https://reviews.llvm.org/D100499
___
cfe-commits mailing list
cfe-commits@list
rsanthir.quic updated this revision to Diff 338539.
rsanthir.quic added a comment.
only the pol128 intrinsic is incompatible with ARM, the rest should be
supported.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100499/new/
https://reviews.llvm.org/D100499
Files:
clang/lib/CodeGen/CG
rsanthir.quic added a comment.
Thanks for looking into this @DavidSpickett ! What you found makes sense. I'll
update this patch to remove only the poly128 vadd from the mapping. I'll also
add another patch that will correctly enable the remaining vadd intrinsics for
ARM.
Repository:
rG LLVM
DavidSpickett added a comment.
Ok, it's behind the aarch64 guard because there's a giant #ifdef around it that
I didn't see. If you move it in `arm_neon.td` down to outside that #ifdef you
get the definitions. Next problem is that the `poly128_t` type isn't
implemented for AArch32. Not sure why
DavidSpickett added a comment.
Both clang and GCC have their issues when it comes to matching the ACLE, so I
wouldn't take the header guard as fact. It could be that we never implemented
the A32 path for these functions/when they were added the document was in
flux/no on ever tried this on A32.
rsanthir.quic added a comment.
As you mentioned, I thought it was only supported due to
`CheckFPAdvSIMDEnabled64`. If the header is also guarding for AArch64 does that
not support the idea that it is AArch64 specific?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
DavidSpickett added a comment.
What's your logic for these being Arm only?
I looked up the ones that were added:
vadd_p8
vadd_p16
vadd_p64
vaddq_p8
vaddq_p16
vaddq_p64
vaddq_p128
E.g.
https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics?search=vadd_p
rsanthir.quic created this revision.
rsanthir.quic added reviewers: t.p.northover, DavidSpickett, labrinea, apazos.
Herald added subscribers: danielkiss, kristof.beyls.
rsanthir.quic requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
The Neon
