[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

2021-04-14 Thread Shu-Chun Weng via Phabricator via cfe-commits
scw added inline comments. Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} ymandel wrote: > Hmm. Looks like we could use smart pointer support in tooling::buildAddress

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

2021-04-14 Thread Shu-Chun Weng via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c5717225e89: [libTooling] Add smart pointer support to the `access` Stencil (authored by scw). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100450/new/ ht

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

2021-04-14 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/unittests/Tooling/StencilTest.cpp:410 + StringRef Id = "id"; + testExpr(Id, Snippet, access(Id, "field"), "(*x).field"); +} Hmm

[PATCH] D100450: [libTooling] Add smart pointer support to the `access` Stencil

2021-04-14 Thread Shu-Chun Weng via Phabricator via cfe-commits
scw created this revision. scw requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This extends smart pointer support beyond the existing `maybeDeref` and `maybeAddressOf`. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1004