This revision was automatically updated to reflect the committed changes.
Closed by commit rG11072a0bdbc0: [RISCV][Clang] Add RVV AMO builtins (authored
by arcbbb).
Changed prior to commit:
https://reviews.llvm.org/D100448?vs=338419&id=339139#toc
Repository:
rG LLVM Github Monorepo
CHANGES
khchen accepted this revision.
khchen added a comment.
This revision is now accepted and ready to land.
LGTM. Please remove the ASM check in upstream patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100448/new/
https://reviews.llvm.org/D10044
arcbbb updated this revision to Diff 338419.
arcbbb added a comment.
re-formatted.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100448/new/
https://reviews.llvm.org/D100448
Files:
clang/include/clang/Basic/riscv_vector.td
clang/test/CodeGen/R
arcbbb updated this revision to Diff 338416.
arcbbb marked 3 inline comments as done.
arcbbb added a comment.
Addressed @khchen's comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100448/new/
https://reviews.llvm.org/D100448
Files:
clang/in
khchen added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:749
+ foreach type = type_list in
+foreach eew_list = [["8", "(Log2EEW:3)"], ["16", "(Log2EEW:4)"],
+["32", "(Log2EEW:5)"], ["64", "(Log2EEW:6)"]] in {
---
arcbbb created this revision.
arcbbb added reviewers: craig.topper, rogfer01, khchen, HsiangKai, evandro,
liaolucy, jrtc27.
Herald added subscribers: vkmr, frasercrmck, dexonsmith, luismarques, apazos,
sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o,
brucehoult, MartinMosbeck
