[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ab513cd3e06: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL (authored by bader). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 345806. bader marked an inline comment as done. bader added a comment. Added documentation to cover conversion rules and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.l

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/docs/SYCLSupport.rst:96 - global_space, constant_space + * - ``__attribute__((opencl_global_device))`` + - global_space I think we should extend conversion rules too. Repository: rG LLVM Github Mo

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 344399. bader marked an inline comment as done. bader added a comment. Added explicit cast checks to Sema tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files:

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/test/SemaSYCL/address-space-conversions.cpp:74 + GLOB = GLOB_DEVICE; + GLOB_DEVICE = GLOB; // expected-error {{assigning '__global int *' to '__global_device int *' changes address space of

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 344393. bader added a comment. Apply code review suggestions and rebase on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/docs/SYCLSupport.rst cl

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

aaron.ballman added inline comments. Comment at: clang/lib/AST/ItaniumMangle.cpp:2495 break; // ::= "SY" [ "global" | "local" | "private" ] case LangAS::sycl_global: Can you also update this comment? Repository: rG LLVM Github Monorep

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added inline comments. Comment at: clang/include/clang/AST/Type.h:489 B == LangAS::opencl_global_host)) || + (A == LangAS::sycl_global && (B == LangAS::sycl_global_device || +

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader updated this revision to Diff 340528. bader added a comment. Rebase on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Address

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

Anastasia added a comment. Ok, this looks like a straightforward addition. I will finalize this review once the parent review is completed though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100396/new/ https://reviews.llvm.org/D100396

[PATCH] D100396: [SYCL] Enable `opencl_global_[host,device]` attributes for SYCL

bader created this revision. Herald added subscribers: Naghasan, ldrumm, dexonsmith, kerbowa, Anastasia, ebevhan, yaxunl, nhaehnle, jvesely, jholewinski. bader requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mo