[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Justin Lebar via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7dd606889925: [clang-rename] Handle designated initializers. (authored by dcastagna, committed by jlebar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Michael Kuperstein via Phabricator via cfe-commits
mkuper added a comment. I defer to Justin, he knows AST much better than I do. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___ cfe-commits mailing list cfe-

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Daniele Castagna via Phabricator via cfe-commits
dcastagna added a comment. Thank you Justin. I'm happy with this now that I finally managed to get rid of the lint errors. Let's wait for Micheal's opinion or until tomorrow and then we can push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1003

Re: [PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Justin Lebar via cfe-commits
I guess you need me or Michael to push this. Happy to do so once you're happy with it. On Mon, Apr 12, 2021 at 11:33 AM Daniele Castagna via Phabricator < revi...@reviews.llvm.org> wrote: > dcastagna updated this revision to Diff 336912. > dcastagna added a comment. > > clang-format again > > >

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Daniele Castagna via Phabricator via cfe-commits
dcastagna updated this revision to Diff 336912. dcastagna added a comment. clang-format again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/RecursiveSymb

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Daniele Castagna via Phabricator via cfe-commits
dcastagna updated this revision to Diff 336900. dcastagna added a comment. Actually run git clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactoring/Re

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Daniele Castagna via Phabricator via cfe-commits
dcastagna updated this revision to Diff 336878. dcastagna added a comment. Fixed clang-format pre-merge lints Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 Files: clang/include/clang/Tooling/Refactori

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Justin Lebar via Phabricator via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. I can't argue with this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100310/new/ https://reviews.llvm.org/D100310 ___

[PATCH] D100310: Add field designated initializers logic in Tooling/Rename

2021-04-12 Thread Daniele Castagna via Phabricator via cfe-commits
dcastagna created this revision. Herald added a subscriber: jfb. dcastagna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang Tooling, and more specifically Refactoring/Rename, have support code to extract source locations given a Unifie