Jim accepted this revision.
Jim added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100266/new/
https://reviews.llvm.org/D100266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Jim added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1217
+defm vmv_x : RVVOp0BuiltinSet<"vmv_x_s", "csil",
+ [["s", "ve", "ev"],
+["s", "UvUe", "UeUv"]]>;
Inden
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100266/new/
https://reviews.llvm.org/D100266
___
khchen added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:1001
+["x", "Uv", "UvUe"]]>;
+}
Jim wrote:
> I am not sure that indent is needed inside let expression. In some cases, it
> don't have inden
Jim added a reviewer: Jim.
Jim added inline comments.
Comment at: clang/include/clang/Basic/riscv_vector.td:993
+defm vmv_v : RVVOutBuiltinSet<"vmv_v_v", "csil",
+ [["v", "Uv", "UvUv"]]>;
+defm vmv_v : RVVOutBuiltinSet<"vmv_v_v", "csilfd"
