On Mon, Sep 14, 2015 at 07:24:11PM -0400, Rafael Espíndola wrote:
> From the driver point of view, how does it know if it is targeting
> illumos or solaris? Do they use different triples?
At this point, they do not, se we can't.
>
> In any case, if there is interest in the future this patch can
From the driver point of view, how does it know if it is targeting
illumos or solaris? Do they use different triples?
In any case, if there is interest in the future this patch can be
extended to work on illumos by
* Creating a shouldUseCxaAtexitByDefault and passing in whatever
information is ne
On Tue, Sep 08, 2015 at 03:28:12PM +0200, Joerg Sonnenberger via cfe-commits
wro> We don't distinguish Solaris and OpenSolaris forks currently. As such,
> changing one for the other is not a good choice, especially since you
> are more likely to find clang users for Illumos, IMO.
>
> https://www.
On Tue, Sep 08, 2015 at 01:32:21PM +0200, Xan López via cfe-commits wrote:
> On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > > What do you consider as recent Solaris? When I asked, I've been told
> > > that Illumos has been providing __cxa_atexit since 2013. As such,
On Tue, Sep 08, 2015 at 01:27:42PM +0200, Xan López via cfe-commits wrote:
> > What do you consider as recent Solaris? When I asked, I've been told
> > that Illumos has been providing __cxa_atexit since 2013. As such,
> > disabling it for the Solaris family by default seems just wrong.
>
> Solaris
On Tue, Sep 08, 2015 at 01:09:02PM +0200, Joerg Sonnenberger via cfe-commits
wrote:
> On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> > There is no __cxa_finalize symbol available on recent Solaris OS
> > versions, so we need this flag to make non trivial C++ programs
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> There is no __cxa_finalize symbol available on recent Solaris OS
> versions, so we need this flag to make non trivial C++ programs run.
What do you consider as recent Solaris? When I asked, I've been told
that Illumos has
On Mon, Sep 07, 2015 at 02:44:23PM -0700, Saleem Abdulrasool wrote:
> > Right. Tried to explain a bit what's going on in the commit message,
> > with a reference to the original commit that removed the flag.
>
>
> Thanks. Would you like me to commit this on your behalf as well?
Yes please. Than
On Mon, Sep 7, 2015 at 10:42 AM, Xan López wrote:
> On Mon, Sep 07, 2015 at 10:38:08AM -0700, Saleem Abdulrasool wrote:
> > The patch LGTM with a minor request for tweaking the commit message to
> have
> > the context about the fact that cxa_finalize.o never shipped, and so this
> > doesn't reall
t; > > > > > >
> > > > > > > @@ -6882,10 +6883,6 @@ void
> > solaris::Linker::ConstructJob(Compilation
> > > > > > &C, const JobAction &JA,
> > > > > > >
> > > > Args.MakeArgString(getToolChain().Get
On Mon, Sep 7, 2015 at 10:34 AM, Xan López wrote:
> OK! So here's the patch with a test.
The patch LGTM with a minor request for tweaking the commit message to have
the context about the fact that cxa_finalize.o never shipped, and so this
doesn't really cause any problems for older releases.
; > > > > -
> > > > > -if (getToolChain().getDriver().CCCIsCXX())
> > > > > - CmdArgs.push_back(
> > > > > -
> > > > Args.MakeArgString(getToolChain().GetFilePath("cxa_finalize.o")));
> > > > >
On Mon, Sep 7, 2015 at 2:28 AM, Xan López wrote:
> On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote:
> > > Ping?
> > >
> >
> > Does this break with older Solaris releases? How far back did this
> change
> > in Solaris? The change itself should really be accompanied with a test
On Sat, Sep 05, 2015 at 12:25:28PM -0700, Saleem Abdulrasool wrote:
> > Ping?
> >
>
> Does this break with older Solaris releases? How far back did this change
> in Solaris? The change itself should really be accompanied with a test.
Hi,
turns out I'm not really sure cxa_finalize.o was ever av
On Fri, Sep 4, 2015 at 1:11 AM, Xan López via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> > There is no __cxa_finalize symbol available on recent Solaris OS
> > versions, so we need this flag to make non trivial C+
On Fri, Aug 28, 2015 at 07:52:17PM +0200, Xan López via cfe-commits wrote:
> There is no __cxa_finalize symbol available on recent Solaris OS
> versions, so we need this flag to make non trivial C++ programs run.
>
> Also stop looking for cxa_finalize.o, since it won't be there.
>
> (This patch s
There is no __cxa_finalize symbol available on recent Solaris OS
versions, so we need this flag to make non trivial C++ programs run.
Also stop looking for cxa_finalize.o, since it won't be there.
(This patch sits on top of a couple of unreviewed patches that make clang
actually work on Solaris,
17 matches
Mail list logo
