r246473.
On 31 August 2015 at 13:30, Xan López wrote:
> Oops, missed this. Here is the updated patch.
>
> And yes please, commit the patch for me.
>
> Cheers,
>
> Xan
>
> On Mon, Aug 31, 2015 at 01:07:35PM -0400, Rafael Espíndola wrote:
>> Do you have a version with the last suggestions? I lgtmed
Oops, missed this. Here is the updated patch.
And yes please, commit the patch for me.
Cheers,
Xan
On Mon, Aug 31, 2015 at 01:07:35PM -0400, Rafael Espíndola wrote:
> Do you have a version with the last suggestions? I lgtmed it conditional on
> it. Do you need someone to commit it for you?
>
Do you have a version with the last suggestions? I lgtmed it conditional on
it. Do you need someone to commit it for you?
On Aug 23, 2015 7:07 PM, "Rafael Espíndola"
wrote:
> SolarisScanLibDirForGCCTriple should start with a lower case. Starting
> it with "scan" would probably also be more in l
SolarisScanLibDirForGCCTriple should start with a lower case. Starting
it with "scan" would probably also be more in line with the code
style.
LGTM
On 11 August 2015 at 16:33, Xan López wrote:
> Hi,
>
> thanks for the review, I was not even aware that this could be
> tested. Adding a test helped
Hi,
thanks for the review, I was not even aware that this could be
tested. Adding a test helped to fix me a couple extra issues (plus the
one you already mentioned). New patch attached.
Xan
On Wed, Aug 05, 2015 at 09:14:30AM -0400, Rafael Espíndola wrote:
> Please git-clang-format this patch.
>
Please git-clang-format this patch.
+ // /usr/gcc/./lib/gcc/../,
The code appends a triple after the "/lib/gcc". Is the comment missing it?
The inner loop has no version comparison. Are you depending on the
directory iteration order?
Can you add a testcase?
On 28 July 2015 at 12:35, Xan López
