rsmith resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
___
dim resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
__
dim accepted this commit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
dim (Auditor)
http://reviews.llvm.org/rL244063
___
cf
jyknight accepted this commit.
jyknight added a comment.
This issue was resolved; hopefully this will inform Phab of that.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
htt
jyknight added a comment.
What's the status of this? It's showing bright red on my review dashboard, and
I'd like to clear it off. :) Am I expected to do anything else here, or is it
just waiting to be merged for the next release now (or, is it not going to be
after all)?
Users:
jyknight (A
dim added a comment.
Note that http://reviews.llvm.org/rL252920 does not apply to 3.7 cleanly, a few
minor modifications are needed.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Au
jyknight added a comment.
The concerns should be fixed by the followup commit
http://reviews.llvm.org/rL252920. If merging to 3.7 branch, both revisions will
need to be included.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compn
tstellarAMD raised a concern with this commit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL244063
_
tstellarAMD resigned from this audit.
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majnemer (Auditor)
rsmith (Auditor)
http://reviews.llvm.org/rL244063
___
cfe-co
On Wed, Nov 4, 2015 at 11:36 AM, James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> jyknight added inline comments.
>
> /cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
> actually follow that spec.
>
> I'm not sure why the library exposes these entry-po
jyknight added inline comments.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 Looks like GCC's behavior does
actually follow that spec.
I'm not sure why the library exposes these entry-points when you're not
supposed to use them. Oop. Sorry that I failed to notice that.
Users:
jyknight (Author
rsmith added a subscriber: rsmith.
rsmith raised a concern with this commit.
/cfe/trunk/lib/CodeGen/CGAtomic.cpp:941-943 According to the GCC documentation
for libatomic:
> for i = __atomic_add_fetch (ptr, j, model) the code generated will be
>
>tmp = __atomic_fetch_add (ptr, j, model);
tstellarAMD added a subscriber: tstellarAMD.
tstellarAMD added auditors: rsmith.
tstellarAMD added a comment.
Hi Richard,
Is this patch OK for the 3.7 branch?
Users:
jyknight (Author, Auditor)
3.7-release (Auditor)
cfe-commits (Auditor)
tstellarAMD (Auditor)
compnerd (Auditor)
majne
dim added a subscriber: dim.
dim added auditors: 3.7-release, cfe-commits, tstellarAMD, jyknight, compnerd,
majnemer.
dim added a comment.
This is a change that was required to be able to use clang 3.7.0 for FreeBSD on
arm. Please merge this to the 3.7 branch. (I already mailed this to James
14 matches
Mail list logo
