[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. Sorry for the delay! And many thanks for reviewing and giving suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138028/new/ https://reviews.llvm.org/D138028

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry updated this revision to Diff 482170. v1nh1shungry added a comment. address the comment's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138028/new/ https://reviews.llvm.org/D138028 Files: clang-tools-extra/clangd/refactor

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added a reviewer: shafik. v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. @shafik Thank you for reviewing and giving suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.ll

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry updated this revision to Diff 481819. v1nh1shungry added a comment. address the comment's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139705/new/ https://reviews.llvm.org/D139705 Files: clang/lib/Sema/SemaInit.cpp cla

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry created this revision. v1nh1shungry added reviewers: aaron.ballman, erichkeane. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current version there is a fix-it for cpp template

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added a comment. Oops! Thank you for your thoughtful consideration. You're right, but I currently get stuck there and need more time. And I prefer to clear the existing patches simultaneously if you don't mind. Or do you think I should merge the modification of this patch into ther

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added a comment. A gentle ping? Sorry if it bothers you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138028/new/ https://reviews.llvm.org/D138028 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry abandoned this revision. v1nh1shungry added a comment. Sorry for the delay. I'd say I was convinced and about to abandon this patch. Sincere apologies for wasting everyone's time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138425/n

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. @sammccall Thank you for reviewing and giving suggestions! I must admit I didn't use it for very long. But I do think this is helpful, at least for templates I'm unfamiliar with. Yes, there is a common situation where people use a meaningless template parameter na

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry added a comment. This patch implements: - Template specialization type - Class template specialization declaration - Variable template specialization declaration - Function specialization declaration It would be sweet to also implement: template constexpr int value = 0; int

[PATCH] D138425: [clangd] Parameter hints for template specialization

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clan

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476692. v1nh1shungry added a comment. - fix qualifiers - fix recursive `decltype` (partly) - support return type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476667. v1nh1shungry added a comment. Avoid type hints for dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 Files: clang-tools-extra/clangd/Inla

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry marked an inline comment as done. v1nh1shungry added a comment. @Trass3r Thank you for the suggestion! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry updated this revision to Diff 476485. v1nh1shungry added a comment. Apply the comment's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138300/new/ https://reviews.llvm.org/D138300 Files: clang-tools-extra/clangd/InlayHints

[PATCH] D138300: [clangd] Support type hints for `decltype(expr)` in variable declarations

v1nh1shungry created this revision. v1nh1shungry added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ex

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

v1nh1shungry added a comment. @ymandel Thank you for reviewing! If this patch is okay to land, could you please help me commit it? Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138204/new/ https://reviews.llvm.org/D138204 __

[PATCH] D138204: [clang-tidy] Fix misc-unused-using-decls for user-defined literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: njames93, ymandel. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. C

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @kadircet Thank you for the excellent suggestions! Will dive into it to figure out the implementations. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using namespace ns1::ns2; +using namespace ns1::ns

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @kadircet Thank you for reviewing and giving suggestions! Please check my reply to your concerns. Sorry if I misunderstood anything. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:294 +} +using namespace ns1::

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc : IdentsToQ

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:212 // Produce replacements to add the qualifiers. std::string Qualifier = printUsingNamespaceName(Ctx, *TargetDirective) + "::"; for (auto Loc : IdentsToQ

[PATCH] D138028: [clangd] Fix action `RemoveUsingNamespace` for inline namespace

v1nh1shungry created this revision. v1nh1shungry added a reviewer: tom-anders. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tool

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry added a comment. @tom-anders Thank you for reviewing and giving suggestions! Hope I use the `llvm::StringSet` correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 _

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry updated this revision to Diff 474808. v1nh1shungry added a comment. Apply the review suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137817/new/ https://reviews.llvm.org/D137817 Files: clang-tools-extra/clangd/refactor/twe

[PATCH] D137817: [clangd] Improve action `RemoveUsingNamespace` for user-defined literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: tom-anders, kadircet. Herald added subscribers: arphaman, mgrang. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Could you please help me commit it? Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailin

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474466. v1nh1shungry added a comment. Modify the name in the hover info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.c

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry added a comment. @kadircet Thanks for your suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474399. v1nh1shungry added a comment. Apply the reviewing suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 474262. v1nh1shungry added a comment. Format codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137550/new/ https://reviews.llvm.org/D137550 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN

[PATCH] D137650: [clangd] Implement hover for string literals

v1nh1shungry updated this revision to Diff 474179. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry added a comment. Seems like I have made things too complex :( Should work for C, C++, and other languages now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 ___

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474149. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474147. v1nh1shungry added a comment. Support different C++ standards Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @tom-anders Thanks for reviewing and for your suggestions! I think your suggestion is excellent, but for now, it is too complex for me to implement. If this patch is okay, could you please help me commit it? Thanks again! Repository: rG LLVM Github Monorepo CH

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 474127. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137550/new/ https://reviews.llvm.org/D137550 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveU

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry updated this revision to Diff 474117. v1nh1shungry added a comment. Improve the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137650/new/ https://reviews.llvm.org/D137650 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry added a comment. @tom-anders Thanks for reviewing and for your suggestions! Comment at: clang-tools-extra/clangd/Hover.cpp:785 + + // TODO: Show string literal's contents + HI.Name = "String Literal"; tom-anders wrote: > Is it really useful to sh

[PATCH] D137650: [clangd] Implement hover for C++ string literals

v1nh1shungry created this revision. v1nh1shungry added reviewers: nridge, tom-anders. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: cla

[PATCH] D137550: [clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry created this revision. v1nh1shungry added reviewers: tom-anders, sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project:

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. In D137494#3910598 , @tom-anders wrote: > Thanks for the fix, LGTM! Do you want me to commit this for you? Yes! Thanks a lot! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473480. v1nh1shungry added a comment. Format codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingN

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @junaire Thank you for reviewing! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/unittests/tweaks/RemoveUsingNamespaceTests.cpp:236 + } + using namespace n^s; + int main() { junaire wrote: > is this a typo? I guess not. I refer to the tests above and I th

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. In D137494#3910500 , @v1nh1shungry wrote: > @tom-anders Thank you for reviewing! > > I tried adding a test but I don't know how to run the tests. > > And I just found that operators declared in a class context are already >

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473478. v1nh1shungry added a comment. Correct the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUs

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry added a comment. @tom-anders Thank you for reviewing! I tried adding a test but I don't know how to run the tests. And I just found that operators declared in a class context are already handled in the existing version, but user-defined literals are not, so I rewrote the comments.

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473477. v1nh1shungry added a comment. Correct the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refactor/tweaks/RemoveUs

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry updated this revision to Diff 473475. v1nh1shungry added a comment. Add a test and rewrite the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137494/new/ https://reviews.llvm.org/D137494 Files: clang-tools-extra/clangd/refact

[PATCH] D137494: [Clangd] Fix the code action `RemoveUsingNamespace`

v1nh1shungry created this revision. v1nh1shungry added reviewers: thesamesam, tom-anders, junaire. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a