[PATCH] D131046: [NFC][clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin added a comment. CI failed since LLVM are still using c++14 to build CCACHE_CPP2=yes CCACHE_HASHDIR=yes /usr/bin/ccache /usr/bin/clang++ -DBUILD_EXAMPLES -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var

[PATCH] D131046: [NFC][clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin updated this revision to Diff 449581. prehistoric-penguin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-replacements/li

[PATCH] D131046: [NFC][clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin updated this revision to Diff 449579. prehistoric-penguin added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.l

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin updated this revision to Diff 449572. prehistoric-penguin added a comment. Format change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-replacem

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin added inline comments. Comment at: clang-tools-extra/clang-apply-replacements/lib/Tooling/ApplyReplacements.cpp:140 +// This replacement is a duplicate of one suggested by another TU. +if (!InsertPos.second) { return; --

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin updated this revision to Diff 449570. prehistoric-penguin added a comment. Update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin updated this revision to Diff 449569. prehistoric-penguin added a comment. Fix per comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131046/new/ https://reviews.llvm.org/D131046 Files: clang-tools-extra/clang-apply-replac

[PATCH] D131046: [clang-tools-extra]Replace find/insert with try_emplace

prehistoric-penguin created this revision. prehistoric-penguin added reviewers: Sockke, avogelsgesang, njames93, harlanhaskins, hokein, alexfh. Herald added a project: All. prehistoric-penguin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D130678: [clang-tools-extra] Refactor to reduce code duplication

prehistoric-penguin updated this revision to Diff 448240. prehistoric-penguin added a comment. Refine commit msg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130678/new/ https://reviews.llvm.org/D130678 Files: clang-tools-extra/clang-apply-repl

[PATCH] D130678: [clang-tools-extra] Refactor to reduce code duplication

prehistoric-penguin created this revision. Herald added a project: All. prehistoric-penguin requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D130678 Files: clang-