[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 445172. omarahmed added a comment. Change removes to remove Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. I don't have push credentials so If everything is okay with the patch, can you push it for me. My email is omarpiratee2...@gmail.com Comment at: clang/include/clang/Format/Format.h:3555 AfterFunctionDefinitionName(false), AfterIfMacros(fal

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438962. omarahmed added a comment. Format files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/d

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438719. omarahmed added a comment. Format files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tools/d

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/include/clang/Format/Format.h:3559 AfterFunctionDefinitionName(false), AfterIfMacros(false), - AfterOverloadedOperator(false), AfterRequiresInClause(false), - AfterRequiresInExpression(false), BeforeN

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438657. omarahmed added a comment. Change the default to APO_Leave Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed marked 3 inline comments as done and an inline comment as not done. omarahmed added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3396 spaceRequiredBeforeParens(Right); +if (Style.SpaceBeforeParens == FormatStyle::SBPO_Custom && +

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/docs/tools/dump_format_style.py:317 pass + elif state == State.InNestedEnum: +if line.startswith('///'): MyDeveloperDay wrote: > Can you show us a screenshot of how these changes will look

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 438433. omarahmed added a comment. - Add version for nestedEnums and nestedFields - Make tests valid Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437980. omarahmed added a comment. Add Parse check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127270/new/ https://reviews.llvm.org/D127270 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/tool

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. As I understand, the default behavior for when the user didn't use `SBPO_Custom` is to add a space in placement operators based on this issue . And, at the same time, the default behavior should be `APO_Never` when we

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437966. omarahmed marked an inline comment as not done. omarahmed added a comment. Refactor the tests and add new parsing logic for nested enums in dump_format_style.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4261 + **AfterPlacementOperator** (``AfterPlacementOperatorStyle``) :versionbadge:`clang-format 14` +Defines in which cases to put a space between new/delete operators and opening parenth

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added a comment. In D127270#3584200 , @curdeius wrote: > Does this patch really fix https://github.com/llvm/llvm-project/issues/54703? > If so, please add test for it. Otherwise remove the link from the summary > (and if possible handle it in a

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed updated this revision to Diff 437468. omarahmed edited the summary of this revision. omarahmed added a comment. Add coverage for placement delete expressions and transform bool option to enum Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed added inline comments. Comment at: clang/lib/Format/Format.cpp:1314 LLVMStyle.SpaceBeforeParensOptions.AfterIfMacros = true; + LLVMStyle.SpaceBeforeParensOptions.AfterPlacementNew = true; LLVMStyle.SpaceBeforeRangeBasedForLoopColon = true; Hazard

[PATCH] D127270: [clang-format] Add space in placement new expression

omarahmed created this revision. omarahmed added a reviewer: MyDeveloperDay. Herald added a project: All. omarahmed requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add AfterPlacementNew option to SpaceBeforeParensOptions to have more contro