[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-04-05 Thread marius doerner via cfe-commits
https://github.com/mariusdr edited https://github.com/llvm/llvm-project/pull/133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-04-04 Thread marius doerner via cfe-commits
mariusdr wrote: Added release notes under "Bug Fixes to C++ Support". Thanks for the review. https://github.com/llvm/llvm-project/pull/132460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-31 Thread marius doerner via cfe-commits
@@ -1646,7 +1646,6 @@ void Preprocessor::ExpandBuiltinMacro(Token &Tok) { // Set up the return result. Tok.setIdentifierInfo(nullptr); - Tok.clearFlag(Token::NeedsCleaning); mariusdr wrote: True, my bad. If the flag is removed we can get asserts on __DAT

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-31 Thread marius doerner via cfe-commits
https://github.com/mariusdr edited https://github.com/llvm/llvm-project/pull/133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-31 Thread marius doerner via cfe-commits
https://github.com/mariusdr edited https://github.com/llvm/llvm-project/pull/133574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-31 Thread marius doerner via cfe-commits
https://github.com/mariusdr updated https://github.com/llvm/llvm-project/pull/133574 >From dd54aa59eabe9c3b7b110f46d82ff5c4d0b88c57 Mon Sep 17 00:00:00 2001 From: marius doerner Date: Sat, 29 Mar 2025 09:21:20 +0100 Subject: [PATCH 1/2] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMa

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-29 Thread marius doerner via cfe-commits
https://github.com/mariusdr updated https://github.com/llvm/llvm-project/pull/133574 >From dd54aa59eabe9c3b7b110f46d82ff5c4d0b88c57 Mon Sep 17 00:00:00 2001 From: marius doerner Date: Sat, 29 Mar 2025 09:21:20 +0100 Subject: [PATCH] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro`

[clang] [clang] Clear `NeedsCleaning` flag after `ExpandBuiltinMacro` (PR #133574)

2025-03-29 Thread marius doerner via cfe-commits
https://github.com/mariusdr created https://github.com/llvm/llvm-project/pull/133574 After builtin macro expansion in `Preprocessor::ExpandBuiltinMacro` the result token may have the `Token::NeedsCleaning` flag set which causes an assertion failure later on when the lexer retrieves the spellin

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-26 Thread marius doerner via cfe-commits
https://github.com/mariusdr created https://github.com/llvm/llvm-project/pull/132460 Closes #131432 Raise an error when placement new is used to modify a const-qualified variable in a constexpr function. Note that diag::note_constexpr_modify_const_type is used since the it is also raised wh

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-25 Thread marius doerner via cfe-commits
mariusdr wrote: > Thanks. Will you need me to merge that for you? Yes, please https://github.com/llvm/llvm-project/pull/132460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-24 Thread marius doerner via cfe-commits
https://github.com/mariusdr updated https://github.com/llvm/llvm-project/pull/132460 >From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001 From: marius doerner Date: Fri, 21 Mar 2025 20:19:57 +0100 Subject: [PATCH 1/3] [clang] Placement new error when modifying consts Raise a

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-23 Thread marius doerner via cfe-commits
https://github.com/mariusdr updated https://github.com/llvm/llvm-project/pull/132460 >From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001 From: marius doerner Date: Fri, 21 Mar 2025 20:19:57 +0100 Subject: [PATCH 1/2] [clang] Placement new error when modifying consts Raise a

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-23 Thread marius doerner via cfe-commits
mariusdr wrote: > The tests should go into a file not under `ByteCode/` since they aren't > specific to the bytecode interpreter. There should be existing placement new > tests in `SemaCXX/`. Thanks for the hint, moved them to clang/test/SemaCXX/cxx2c-constexpr-placement-new.cpp https://gith

[clang] [clang] Placement new error when modifying consts (PR #132460)

2025-03-23 Thread marius doerner via cfe-commits
https://github.com/mariusdr updated https://github.com/llvm/llvm-project/pull/132460 >From d4af25b14fb21f50c3771cce4595ca5c1bb920a7 Mon Sep 17 00:00:00 2001 From: marius doerner Date: Fri, 21 Mar 2025 20:19:57 +0100 Subject: [PATCH 1/2] [clang] Placement new error when modifying consts Raise a