[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

StephenFan added a comment. In D70401#3873874 , @pcwang-thead wrote: > In D70401#3873347 , @luojia wrote: > >> Hello! Any further updates to this patch? It seems like all the inline >> comments have been resolved.

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added a comment. In D129448#3669296 , @vitalybuka wrote: > I am not sure what to do with this patch. I really prefer to avoid it to > minimize the risk of regressions. > > We probably considered/prototyped to insert starts like in this soluti

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 StephenFan wrote: > vitalybuka wrote: > > It assume this will break Msan > > Tr

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:78 break; case 2: bar(&x, 1); vitalybuka wrote: > vitalybuka wrote: > > StephenFan wrote: > > > vitalybuka wrote: > > > > vitalybuka wrote: > > > > > Please check for lifeti

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 445420. StephenFan added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. 1. Rebase. 2. Add a test case of goto_bypass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129448/ne

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan added inline comments. Comment at: clang/test/CodeGen/lifetime2.c:42 +// O2: @llvm.lifetime.start.p0i8(i64 1 bar(&x, 1); +// O2: @llvm.lifetime.end.p0i8(i64 1 vitalybuka wrote: > It assume this will break Msan > Transforms/Instrumentation

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan updated this revision to Diff 444701. StephenFan added a comment. 1. Record bypassed lifetime start markers in codegenfunction class instead of lexicalscope. Since bypassed variables may be defined when lexicalscope is nullptr. This can also fix test fail of use-after-scope-goto.cpp.

[PATCH] D126742: [RISCV][Clang] Support RVV policy functions.

StephenFan added inline comments. Herald added a subscriber: nlopes. Comment at: clang/lib/Sema/SemaRVVLookup.cpp:378-388 +} else { + if (IsPrototypeDefaultTU) { +DefaultPolicy = Policy::TU; +if (HasPolicy) + BuiltinName += "_tu"; + } else {

[PATCH] D129448: [CodeGen][Asan] Emit lifetime intrinsic for bypassed label

StephenFan created this revision. StephenFan added reviewers: MaskRay, vitalybuka, rsmith. Herald added a project: All. StephenFan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix https://github.com/llvm/llvm-project/issues/56356 For fol

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

StephenFan added a comment. Why not use `env PATH=` in the lit run line to clear the `PATH` env variable? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D127589 ___ cf

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. Thanks @MaskRay, @asb ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG429cbac03906: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified (authored by StephenFan). Changed prior to commit: https://re

[PATCH] D122556: [RISCV] Add definitions for Xiangshan processors.

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:547 +def : ProcessorModel<"xiangshan-nanhu", NoSchedModel, [Feature64Bit, + FeatureStdExtM, + F

[PATCH] D122588: [RISCV][test] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5900401b147: [RISCV][test] Make PATH empty when testing --gcc-toolchain is… (authored by StephenFan). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 418774. StephenFan added a comment. Herald added a subscriber: sunshaoce. Address @MaskRay 's comments. 1. explicit default-argument to avoid error-prone 2. change riscv64 test to test the case when `-mno-relax -mrelax` specified. Is the change of riscv64

[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

StephenFan updated this revision to Diff 418771. StephenFan added a comment. Herald added a subscriber: sunshaoce. Address @MaskRay 's comments Change log: 1. Update test in riscv32-toolchain.c 2. Make system-windows UNSUPPORTED Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D122588: [RISCV] Make PATH empty when testing --gcc-toolchain is multilib_riscv_elf_sdk

StephenFan created this revision. StephenFan added reviewers: MaskRay, khchen, asb, jrtc27. Herald added subscribers: s, VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. @jrtc27, @kito-cheng Do you have any other comments ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing lis

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 418379. StephenFan added a comment. Herald added a subscriber: MaskRay. Grammatical fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/T

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. Herald added subscribers: s, arichardson. Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing list cfe-c

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 413774. StephenFan added a comment. Address @kito-cheng 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 411730. StephenFan added a comment. Address @jrtc27 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp clan

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan updated this revision to Diff 411724. StephenFan added a comment. fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120639/new/ https://reviews.llvm.org/D120639 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/test/Driver/riscv

[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

StephenFan created this revision. StephenFan added reviewers: asb, jrtc27, craig.topper. Herald added subscribers: VincentWu, luke957, achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, M

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

StephenFan added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:115 + return make_filter_range(SupportedExtensionInfos, + [&](const RISCVSupportedExtensionInfo &ExtInfo) { + return ExtInfo.Name == ExtName; ---

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added a comment. In D93298#2544775 , @asb wrote: > In D93298#2544459 , @StephenFan > wrote: > >> According to @jrtc27 's review that is >> "As for Zfinx itself, well, the idea is fine, but I really det

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added a comment. In D93298#253 , @asb wrote: > I started reviewing this alongside the specification in > https://github.com/riscv/riscv-zfinx/blob/master/Zfinx_spec.adoc. At the time > of writing, it seems to define "zfinx" but not "zfhinx

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1663 +OperandMatchResultTy RISCVAsmParser::parseGPRasFPR(OperandVector &Operands) { + switch (getLexer().getKind()) { StephenFan wrote: > jrtc27 wrote: > > Why can

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:1663 +OperandMatchResultTy RISCVAsmParser::parseGPRasFPR(OperandVector &Operands) { + switch (getLexer().getKind()) { jrtc27 wrote: > Why can't you just use parseR

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp:983 + } + return Match_InvalidOperand; It seems like that this function is not useful. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https:/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

StephenFan added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfinx.td:102 +: InstAlias; + use GPR as instruction operand may cause the codegen part of zfinx report errors. Because the GPR has data type i32 or i64, However, the zfinx will