[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin abandoned this revision. sunlin added a comment. Close it for ignore these headers from command line. It is included from chain: "include/clang/Basic/TargetBuiltins.h" --> "clang/Basic/BuiltinsARM.def" --> "include/clang/Basic/arm_cde_builtins.inc"... Repository: rG LLVM Github Monore

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. Thanks all of you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin marked an inline comment as done. sunlin added a comment. Hi @MaskRay , The patch is updated as your comment. Please review again. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin updated this revision to Diff 368812. sunlin added a comment. Update for do not add duplicate path Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 Files: clang/lib/Driver/ToolChains/Linux.cpp I

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:308 addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); + } MaskRay wrote: > Add `if (OSLibDir != "lib")` thumbs up. Repos

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. @MaskRay Any more questions for this line change? Thanks : ) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.llvm.org/D108286 ___ cfe-commits mailing lis

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:307 + if (StringRef(D.Dir).startswith(SysRoot)) { addPathIfExists(D, D.Dir + "/../lib", Paths); +addPathIfExists(D, D.Dir + "/../" + OSLibDir, Paths); MaskRay wrote: > Is `D

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a comment. In D108286#2952511 , @MaskRay wrote: > Please provide more information: the platform name and the output of `g++ > empty.cc '-###' |& sed -E 's/ "?-[LiIr]/\n&/g'` > > Note that there is a FIXME. It's unclear why your platform need

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin added a subscriber: MaskRay. sunlin added a comment. Hi @MaskRay Please help to review this change. I compiled clang with "-DLLVM_LIBDIR_SUFFIX=64" "-DLIBCXX_LIBDIR_SUFFIX=64" "-DLIBCXXABI_LIBDIR_SUFFIX=64" and the clang 12 work as expected. But after I turn to clang 13, it's failed to

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin updated this revision to Diff 367167. sunlin added a comment. [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64 remove unrelated files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108286/new/ https://reviews.l

[PATCH] D108286: [clang][Driver][Linux] fix regression issue when define LIBCXX_LIBDIR_SUFFIX=64

sunlin created this revision. Herald added a subscriber: mgorny. sunlin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang failed to compile c++ when LIBCXX_LIBDIR_SUFFIX=64 is defeined for the lib path "../lib64" are not be included.

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin added a comment. Yes, a CMake option is a good idea for this. I'll update this change to add a new CMake option for who don't want all the headers (default OFF to follow exist behavior) . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103080

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin added a comment. Hi @kristof.beyls The original `lib/clang/12.0.1/include` is about total ~10M, and the `arm*.h` take about ~5M. Ignore these unused header files will save the developers who work on the low storage device. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D103080: [CMake] Ignore arm_*.h for non-ARM build

sunlin created this revision. Herald added subscribers: kristof.beyls, mgorny. sunlin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Copy the arm_*.h files only "ARM" is in build targets. Repository: rG LLVM Github Monorepo https://re