[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407300. devjgm added a comment. - accepted ymandel's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveC

[PATCH] D119370: [clang-tidy] add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407288. devjgm added a comment. Accepted ymandel's suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-extra/clang-tidy/performance/MoveCo

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm updated this revision to Diff 407267. devjgm added a comment. Here is also updated the documentation to include the new option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119370/new/ https://reviews.llvm.org/D119370 Files: clang-tools-

[PATCH] D119370: feat: add option performance-move-const-arg.CheckMoveToConstRef

2022-02-09 Thread Greg Miller via Phabricator via cfe-commits
devjgm created this revision. Herald added a subscriber: carlosgalvezp. devjgm requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. This option allows callers to disable the warning from https://clang.llvm.org/extra/clang-tidy/checks

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

2021-09-17 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. The test patch worked and test is now passing again. Thanks for the quick help on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109234/new/ https://reviews.llvm.org/D109234 __

[PATCH] D109234: [PGO] Change ThinLTO test for targets with loop unrolling disabled

2021-09-16 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

2021-05-10 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. In D101030#2746957 , @jdoerfert wrote: > In D101030#2746770 , @gregmiller > wrote: > >> In D101030#2745513 , @jdoerfert >> wrote: >> >>> In D

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

2021-05-09 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. In D101030#2745513 , @jdoerfert wrote: > In D101030#2745429 , @gregmiller > wrote: > >> Hello, We are maintaining a downstream version of the monorepo based on the >> LLVM main branch

[PATCH] D101030: [OpenMP] Overhaul `declare target` handling

2021-05-07 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. Hello, We are maintaining a downstream version of the monorepo based on the LLVM main branch. We have not transitioned to the new PM yet. In a recent attempt to merge the latest upstream commits into our monorepo we came across the following test failures after your

[PATCH] D95753: [Coverage] Store compilation dir separately in coverage mapping

2021-02-22 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. Hello, we are seeing failures like below: Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment set-up. [--] 1 test from Parame

[PATCH] D96865: [Driver] Honor "-gdwarf-N" at any position for assembler sources

2021-02-19 Thread greg miller via Phabricator via cfe-commits
gregmiller added a comment. Hello, We are seeing failures like below: -- Note: Google Test filter = ParameterizedCovMapTest/CoverageMappingTest.skip_duplicate_function_record/0 [==] Running 1 test from 1 test case. [--] Global test environment set