[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

2022-07-13 Thread dana koch via Phabricator via cfe-commits
3405691582 added a comment. In D129654#3650534 , @brad wrote: > In D129654#3650412 , @3405691582 > wrote: > >> Tested change on OpenBSD resolves downstream issues. > > What issues? As mentioned, this replicates

[PATCH] D129654: [Clang][Driver] Fix include paths for `--sysroot /` on OpenBSD/FreeBSD

2022-07-13 Thread dana koch via Phabricator via cfe-commits
3405691582 accepted this revision. 3405691582 added a comment. This revision is now accepted and ready to land. LGTM. Tested change on OpenBSD, was not able to check FreeBSD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129654/new/ https://reviews

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

2020-08-23 Thread dana koch via Phabricator via cfe-commits
3405691582 added a comment. Thanks! please commit on my be half as appropriate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

2020-08-23 Thread dana koch via Phabricator via cfe-commits
3405691582 updated this revision to Diff 287263. 3405691582 edited the summary of this revision. 3405691582 added a comment. Those platforms still use the legacy mechanism in `InitHeaderSearch.cpp`. For platforms which have moved include handling to the driver, the mechanism in `InitHeaderSearch

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

2020-08-22 Thread dana koch via Phabricator via cfe-commits
3405691582 updated this revision to Diff 287238. 3405691582 added a comment. Finally got the formatting fixed properly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/lib/Driver/ToolChain

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

2020-08-22 Thread dana koch via Phabricator via cfe-commits
3405691582 updated this revision to Diff 287237. Herald added a subscriber: fedor.sergeev. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86412/new/ https://reviews.llvm.org/D86412 Files: clang/lib/Driver/ToolChains/OpenBSD.cpp clang/lib/Driver/ToolChains/OpenBSD.h Index: clang/lib/D

[PATCH] D86412: [clang][Driver] Implement AddClangSystemIncludeArgs and HasNativeLLVMSupport for the OpenBSD clang driver.

2020-08-22 Thread dana koch via Phabricator via cfe-commits
3405691582 created this revision. 3405691582 added a reviewer: brad. Herald added a project: clang. Herald added a subscriber: cfe-commits. 3405691582 requested review of this revision. If not overridden, `AddClangSystemIncludeArgs`'s implementation is empty, so by default, no system include args