[PATCH] D129799: [clang-tidy] Add CLANG_TIDY_CONFUSABLE_CHARS_GEN cmake setting to avoid building when cross compiling

trcrsired added a comment. Hi i have a question. Does llvm provide a general toggle to set all those things with a directory? It becomes unmanagable since the end of llvm 15. like LLVM_NATIVE_TOOL_DIR some thing like that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D117888: [clang][driver][wasm] Support -stdlib=libstdc++ for WebAssembly

expnkx reopened this revision. expnkx added a comment. This revision is now accepted and ready to land. This patch is simply wrong. cqwrteur@Home-Server:~/fast_io_cleanup/fast_io/examples/0001.helloworld$ clang++ -o helloworld helloworld.cc -Ofast -std=c++2b -s -flto -fuse-ld=lld --target=wasm3

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3030874 , @erichkeane wrote: > In D110485#3030853 , @expnkx wrote: > >> clang simply just does not truly support everything msvc supports. There are >> no things that deals [[m

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. clang simply just does not truly support everything msvc supports. There are no things that deals [[msvc::]] attributes at all in the clang. In fact the point of using clang on windows is that we do not want to do the same as Microsoft does. Support [[no_unique_address]

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375775. expnkx added a comment. clang format + clang tidy all clang tests pass locally. flang is bugged. Do not know why flang cannot find llvm-jxx CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files:

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375758. expnkx added a comment. fixing clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/lib/AST/RecordLayoutBuilder.cpp Index: clang/lib/AST/RecordLayoutBuilder.cpp

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375720. expnkx added a comment. it should first update the field and then test no_unique_address CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/lib/AST/RecordLayoutBuilder.cpp Index: clang

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375690. expnkx added a comment. I cannot find out where to add attribute that starts with msvc::x. I am just applying this "potential" patch to the clang upstream. In the future we can just remove TargetItaniumCXXABI attr in the clang table gen file witho

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375468. expnkx added a comment. should be diff3 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/Preprocessor/has_attribute.cpp clang/test/SemaCXX/cx

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3026533 , @rjmccall wrote: > We should not add a standard feature with ABI impact if we aren't certain > we're going to match MSVC's ABI on it. I'm sorry, but this needs to wait > until there's an MSVC release that of

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. In D110485#3026533 , @rjmccall wrote: > We should not add a standard feature with ABI impact if we aren't certain > we're going to match MSVC's ABI on it. I'm sorry, but this needs to wait > until there's an MSVC release that of

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375466. expnkx added a comment. itanium + microsoft test both CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/SemaCXX/cxx2a-no-unique-address.cpp In

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375461. expnkx added a comment. I just find that Preprocessor test has a windows (msvc not gnu) specific test that tests no_unique_address. add that to patch and see whether it is mergable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx added a comment. ninja: error: unknown target 'check-libc', did you mean 'check-lit'? what's wrong with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 ___ cfe-commits mailing list cfe-

[PATCH] D110485: Support [[no_unique_address]] for all targets.

expnkx updated this revision to Diff 375431. expnkx added a comment. do not know why it cannot be built. upload and then verify again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110485/new/ https://reviews.llvm.org/D110485 Files: clang/include/clang/Basic/Attr.td clang/test/SemaC