Hi Aaron,
I don't think we need to backport this to 16.x. Since the previous patch
https://reviews.llvm.org/D146986 doesn't get backported too. The patch itself
is mainly for the implementation of std modules in libcxx. And the std modules
in libcxx should target 17.x as far as I know. So it lo
Hi Bruno,
We talked about removing `-fcoroutines-ts` in
https://github.com/llvm/llvm-project/issues/59110
and https://reviews.llvm.org/D108697. I raised the example you used here. And
the conclusion
is that this is the clang's policy for `-f*-ts` options. The same thing happens
for -fconcepts-t
Hi David,
This is the reproduce link from godbolt: https://godbolt.org/z/nEc7WYKnq. It
is weird that it requries `-Wunused-but-set-parameter` instead of
`-Wunused-parameter`. The bug exists in all versions of GCC9. And it gets fixed
in GCC10 and later. Personally, I feel it looks better to supp
Hi Richard,
Sorry for disturbing. I sent https://reviews.llvm.org/D115610 to try to fix
this.
BTW, the example you posted might not work with libstdc++, here is a bug I
reported: https://github.com/llvm/llvm-project/issues/51873
Thanks,
Chuanqi
--
Hi Richard,
Thanks for reporting this! I found the reason that why it didn't get tested
previously is that we didn't use `extern "C"/"C++"` actually since we
implemented partitions internally. Sorry for confusing. I would try to work on
it.
Thanks,
Chuanqi
---
