[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zhizhouy added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, MaskRay wrote: > zhizhouy wrote: > > MaskRay wrote: > > > If there is no strong need for

[PATCH] D83013: [LPM] Port CGProfilePass from NPM to LPM

zhizhouy added inline comments. Comment at: llvm/tools/opt/opt.cpp:281 +static cl::opt EnableCallGraphProfile( +"enable-call-graph-profile", cl::init(true), cl::Hidden, MaskRay wrote: > If there is no strong need for tuning this, please delete the option an

[PATCH] D62627: [NFC] Do not run CGProfilePass when not using integrated assembler

zhizhouy updated this revision to Diff 252143. zhizhouy marked 4 inline comments as done. zhizhouy retitled this revision from "[NFC] Do not run CGProfilePass when -fno-integrated-as is on" to "[NFC] Do not run CGProfilePass when not using integrated assembler". zhizhouy added a comment. Thanks

[PATCH] D62627: [NFC] Do not run CGProfilePass when -fno-integrated-as is on

zhizhouy updated this revision to Diff 252129. zhizhouy marked 2 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: manojgupta. zhizhouy removed a subscriber: manojgupta. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repositor

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rC347897: set default max-page-size to 4KB in lld for Android Aarch64 (authored by zhizhouy, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https:/

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy added a comment. Thanks for the review and comments! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55029/new/ https://reviews.llvm.org/D55029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D55029: set default max-page-size to 4KB in lld for Android Aarch64

zhizhouy created this revision. zhizhouy added reviewers: srhines, danalbert, ruiu, chh. Herald added subscribers: cfe-commits, kristof.beyls, javed.absar. This patch passes an option '-z max-page-size=4096' to lld through clang driver. This is for Android on Aarch64 target. The lld default page

[PATCH] D30760: Record command lines in objects built by clang, Clang part

zhizhouy updated this revision to Diff 93403. zhizhouy marked 2 inline comments as done. zhizhouy added a comment. Added testcase for recording other useful options. https://reviews.llvm.org/D30760 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/debug-options.c Index: test/Driver/debug

[PATCH] D30760: Record command lines in objects built by clang, Clang part

zhizhouy updated this revision to Diff 93401. zhizhouy marked 2 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a comment. Added two more testcases, one is options with both grecord-gcc-switches and gno-record-gcc-switches; the other one is testing if "-o -"

[PATCH] D30760: Record command lines in objects built by clang, Clang part

zhizhouy updated this revision to Diff 93011. zhizhouy added a comment. Added tests into test/Driver/debug-options.c. Thanks. https://reviews.llvm.org/D30760 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/debug-options.c Index: test/Driver/debug-options.c =

[PATCH] D30760: Record command lines in objects built by clang, Clang part

zhizhouy updated this revision to Diff 93003. zhizhouy marked 3 inline comments as done. zhizhouy added a comment. Checked both grecord-gcc-swtiches and gno-record-gcc-switches. Modified testcases for it. https://reviews.llvm.org/D30760 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/gr

[PATCH] D30760: Record command lines in objects built by clang, Clang part

zhizhouy updated this revision to Diff 92885. zhizhouy retitled this revision from "Record command lines in objects built by clang" to "Record command lines in objects built by clang, Clang part". zhizhouy edited the summary of this revision. zhizhouy added a reviewer: aprantl. zhizhouy added a co

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy added a comment. Hi aprantl, thanks for replying. I checked the usage of DwarfDebugFlags, it seems that it really did the same work of recording command line options. And I noticed that it is set to false by default. Is it because of some concerns like the debug info size? Is it prope

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy updated this revision to Diff 92546. zhizhouy marked 3 inline comments as done. zhizhouy edited the summary of this revision. zhizhouy added a reviewer: dblaikie. zhizhouy added a comment. Herald added a subscriber: mehdi_amini. Fixed George's comments. Still need to create a test for th

[PATCH] D30760: Record command lines in objects built by clang

zhizhouy updated this revision to Diff 92410. zhizhouy added a comment. Re-implemented the the patch: reusing -grecord-gcc-switches from gcc instead of passing arguments to DiagnosticsEngine. If user specify the -grecord-gcc-switches in command line, Clang will start to record it in Driver, and