[PATCH] D121175: [clang] Add -Wstart-no-unknown-warning-option/-Wend-no-unknown-warning-option.

condy added a comment. IMHO, it's the duty of build systems. CMake provides `check_cxx_compiler_flag` to report unknown options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121175/new/ https://reviews.llvm.org/D121175 __

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2769811 , @eugenis wrote: > I think it is too hit-and-miss to add even under a flag. It's just not the > right approach - but I also don't know what the right approach would be. > > Perhaps adding a small left redzone fo

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy marked 3 inline comments as done. condy added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556 + uint64_t RZ = 0; + if (SizeInBytes < MinRZ / 2) { +// Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is ---

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy updated this revision to Diff 346612. condy added a comment. Apply optimization when SizeInBytes <= MinRZ/2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 Files: clang/test/CodeGen/asan-globals-a

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764357 , @eugenis wrote: > You are adding a new global to every translation unit. > > - Private linkage would not allow them to be merged, this can have > significant binary size and RAM overhead. Do you suggest linkon

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy added a comment. In D102592#2764085 , @vitalybuka wrote: > Would you mind to add compiler-rt/test/asan which triggers this one? Yes, I will. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy marked an inline comment as done. condy added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2556-2559 + // Reduce redzone size for small size objects, e.g. int, char[1]. MinRZ is at + // least 32 bytes, optimize when SizeInBytes is

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy updated this revision to Diff 346055. condy added a comment. Update as suggected Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D102469 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeG

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345786. condy added a comment. Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asan-gl

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345784. condy added a comment. Fix all tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/asa

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345777. condy added a comment. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Files: clang/test/CodeGen/asan-globals-alias.cpp clang/test/CodeGen/as

[PATCH] D102592: [sanitizer] Caught global buffer underflow for first variable

condy updated this revision to Diff 345767. condy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix some tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102592/new/ https://reviews.llvm.org/D102592 Fil

[PATCH] D102469: [sanitizer] Reduce redzone size for small size global objects

condy updated this revision to Diff 345386. condy added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix clang/codegen tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102469/new/ https://reviews.llvm.org/D10

[PATCH] D90448: [clang] Add type check for explicit instantiation of static data members

condy added a comment. The tests failed though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90448/new/ https://reviews.llvm.org/D90448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis