[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

2023-02-06 Thread Zhikai Zeng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc24cdd58a144: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine (authored by Backl1ght). Repository: rG LLVM Github Monorepo C

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_NextLineOnly

2023-02-05 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 494903. Backl1ght added a comment. fix typo and add release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-04 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 494821. Backl1ght added a comment. add more unittest CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Form

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-03 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3891 + * ``PCIS_OnlyNextLine`` (in configuration: ``OnlyNextLine``) +Put all constructor initializers on the next line if they fit. @HazardyKnusperkeks Maybe I misunder

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-02 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght marked an inline comment as done. Backl1ght added a comment. In D143091#4097534 , @HazardyKnusperkeks wrote: > An entry in the changelog would be nice. It is already added I think. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091

[PATCH] D143091: [clang-format] PackConstructorInitializers support PCIS_OnlyNextLine

2023-02-02 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 494281. Backl1ght added a comment. adapt suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143091/new/ https://reviews.llvm.org/D143091 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Forma

[PATCH] D143091: https://github.com/llvm/llvm-project/issues/60241

2023-02-01 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fixes h

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

2023-01-20 Thread Zhikai Zeng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG58751f943f2f: [clang-format] SortUsingDeclarations support lexicographic order (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

2023-01-17 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141694/new/ https://reviews.llvm.org/D141694 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

2023-01-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 489193. Backl1ght added a comment. 1. Update example for SUD_Never 2. Use capital letters for variables and arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141694/new/ https://reviews.llvm.org/D141694 Files: clang/docs/ClangFormatStyle

[PATCH] D141694: [clang-format] SortUsingDeclarations support lexicographic order

2023-01-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: MyDeveloperDay, rymiel. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix https://github.com/llvm/

[PATCH] D140843: [clang-format] fix template closer followed by >

2023-01-06 Thread Zhikai Zeng via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb62906b0d10f: [clang-format] fix template closer followed by > (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140843/new/ https://re

[PATCH] D140843: [clang-format] fix template closer followed by >

2023-01-04 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:169-171 +CurrentToken->getStartOfNonWhitespace() == +CurrentToken->Next->getStartOfNonWhitespace().getLocWithOffset( +-1)) { MyDevelop

[PATCH] D140843: [clang-format] fix template closer followed by >

2023-01-04 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 486248. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140843/new/ https://reviews.llvm.org/D140843 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTest.cpp clang/unittests/Format/TokenAnnotatorTest.cpp Index: clang/u

[PATCH] D140843: [clang-format] fix template closer followed by >

2023-01-03 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. In D140843#4022673 , @MyDeveloperDay wrote: > I'm good with this but I'd be interesting in @owenpan and > @HazardyKnusperkeks opinion. Yes, this is what I understand. And I will add an annotator test later. This patch is j

[PATCH] D140843: [clang-format] fix template closer followed by >

2023-01-02 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is to

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

2022-12-16 Thread Zhikai Zeng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG95c1a17433b9: [clang-format] add config parse test for short lambda (authored by Backl1ght). Changed prior to commit: https://reviews.llvm.org/D14

[PATCH] D140105: [clang-format] add missing config parse test for short lambda

2022-12-15 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D140105 Files:

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

2022-12-15 Thread Zhikai Zeng via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7b36538156b7: [clang-format] make doc for SLS_Inline more clearly (authored by Backl1ght). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

2022-12-14 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. In D139937#3994044 , @HazardyKnusperkeks wrote: > In D139937#3993641 , @Backl1ght > wrote: > >> In D139937#3992987 , >> @HazardyKnusperkeks w

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

2022-12-14 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. In D139937#3994044 , @HazardyKnusperkeks wrote: > In D139937#3993641 , @Backl1ght > wrote: > >> In D139937#3992987 , >> @HazardyKnusperkeks w

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. In D139937#3992987 , @HazardyKnusperkeks wrote: > In D139937#3992098 , @Backl1ght > wrote: > >> OMG! I just looked into git history and last edition of this line happened >> about 4 y

[PATCH] D139937: [clang-format] make doc for SLS_Inline more clearly

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 482530. Backl1ght retitled this revision from "[clang-format] fix typo in doc for SLS_Inline" to "[clang-format] make doc for SLS_Inline more clearly". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 File

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. Seems like I have misunderstood it, after some test I'm sure that it means merge if its an argument of a function. I think there are something todo to make the doc more clearly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. OMG! I just looked into git history and last edition of this line happened about 4 years ago. Am I doing it wrong? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139937/new/ https://reviews.llvm.org/D139937 _

[PATCH] D139937: [clang-format] fix typo in doc for SLS_Inline

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, MyDeveloperDay. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-13 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added inline comments. Comment at: clang/lib/Format/Format.cpp:809 Style.AllowShortCaseLabelsOnASingleLine); +IO.mapOptional("AllowShortCompoundRequirementOnASingleLine", + Style.AllowShortCompoundRequirementOnASingleLine);

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

2022-12-12 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght added a comment. I just find out I miss one case like below template concept c = requires(T x) { { x + 1 } -> std::same_as; }; Since I split AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine into two pathes, I can not fix this until AllowSho

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

2022-12-12 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added reviewers: HazardyKnusperkeks, rymiel. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format brace wrapp

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

2022-12-12 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 482066. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D139786 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineF

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine

2022-12-12 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 482062. Backl1ght retitled this revision from "[clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine" to "[clang-format] AllowShortRequiresExpressionOnASingleLine". Backl1ght edited the summary of this revi

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

2022-12-11 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght updated this revision to Diff 481918. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D139786 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/Unwrapped

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

2022-12-11 Thread Zhikai Zeng via Phabricator via cfe-commits
Backl1ght created this revision. Backl1ght added a reviewer: OwenCax. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format did not take requires into co