zibi marked an inline comment as done.
zibi added inline comments.
Comment at: clang/test/SemaCXX/init-priority-attr.cpp:26
Two foo __attribute__((init_priority(101))) ( 5, 6 );
+#if defined(__MVS__)
+ #if defined(SYSTEM)
aaron.ballman wrote:
> Rather than using
zibi updated this revision to Diff 306753.
zibi added a comment.
Make test cleaner.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Basic/Att
zibi updated this revision to Diff 306524.
zibi marked an inline comment as done.
zibi added a comment.
updated doc. and test as requested
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91565/new/
https://reviews.llvm.org/D91565
Files:
clang/incl
zibi marked an inline comment as done.
zibi added inline comments.
Comment at: clang/include/clang/Basic/Attr.td:384
+def ExcludeTarget : TargetSpec {
+ let CustomCode = [{ !Target.getTriple().isOSzOS() }];
aaron.ballman wrote:
> This is not a very descriptive
zibi updated this revision to Diff 306183.
zibi marked an inline comment as done.
zibi added a comment.
Moving macro to common place as requested. This makes assumption that MS and
Apple restrictions were lifted at some point.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
zibi updated this revision to Diff 306162.
zibi marked an inline comment as done.
zibi added a comment.
Herald added a reviewer: aaron.ballman.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I moved the logic from `memory_resource.cpp` to `__config` as since I'm not
famili
zibi added a comment.
LGTM, though not sure why comment is referencing -fshort-enums=0.
If '=0' is not significant perhaps delete it to remove confusion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89801/new/
https://reviews.llvm.org/D89801
zibi added a comment.
Eli, if you have trouble committing this please let me know. Not sure what is
happening.
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
zibi added a comment.
Yes, please do the commit, thank you.
In https://reviews.llvm.org/D37861#878194, @efriedma wrote:
> LGTM.
>
> Do you want me to commit this for you?
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@
zibi added a comment.
ping
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zibi added a comment.
Please be aware that I don't have the commit permission yet since this is my
first patch. I will rely on somebody to push it to the trunk.
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zibi updated this revision to Diff 115838.
zibi added a comment.
original + review changes
https://reviews.llvm.org/D37861
Files:
include/clang/Lex/PPCallbacks.h
lib/Frontend/PrintPreprocessedOutput.cpp
lib/Lex/Pragma.cpp
test/Preprocessor/pragma_assume_nonnull.c
Index: test/Preprocess
zibi marked 2 inline comments as done.
zibi added a comment.
Good catch, thank you. I submitted a new patch.
https://reviews.llvm.org/D37861
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
zibi updated this revision to Diff 115643.
zibi added a comment.
Addressing the review.
https://reviews.llvm.org/D37861
Files:
lib/Frontend/PrintPreprocessedOutput.cpp
test/Preprocessor/pragma_assume_nonnull.c
Index: test/Preprocessor/pragma_assume_nonnull.c
==
zibi created this revision.
Herald added subscribers: kbarton, nemanjai.
When #pragma clang assume_nonnull begin || end is present in the source it is
completely gone from pre-processed output when compiled with -E or -P. This
patch make sure the pragma is preserved. I included 1 test case which
15 matches
Mail list logo
