yshui wrote:
@HighCommander4 thanks for looking into this! I think this can be closed, right?
https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
https://github.com/yshui closed https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yshui wrote:
@HighCommander4 It's been a while. I think I was trying to ignore everything
but the main file in CollectMacros, but the naive approach i used wasn't working
https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe
https://github.com/yshui updated https://github.com/llvm/llvm-project/pull/99514
>From 6e5d8d8e04678d80b3139c6d6129da88df57c945 Mon Sep 17 00:00:00 2001
From: Yuxuan Shui
Date: Thu, 18 Jul 2024 16:07:45 +0100
Subject: [PATCH] [clangd] [IncludeCleaner] Use correct file ID
---
clang-tools-extra/
yshui wrote:
Good question. I will try to add one once I figure out how this test system
works
https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
https://github.com/yshui updated https://github.com/llvm/llvm-project/pull/99514
>From 08083ebb5637b84426afd059ee162cf085bfa823 Mon Sep 17 00:00:00 2001
From: Yuxuan Shui
Date: Thu, 18 Jul 2024 16:07:45 +0100
Subject: [PATCH] [clangd] [IncludeCleaner] Use correct file ID
---
clang-tools-extra/
yshui wrote:
Looks like I definitely don't understand what's going on. Instead let me try a
more conservative fix. This should preserve what the current code is doing and
just fix the assertion failure.
https://github.com/llvm/llvm-project/pull/99514
___
https://github.com/yshui updated https://github.com/llvm/llvm-project/pull/99514
>From 93b2fec10a374fd09b128a70052f9a17c176aa20 Mon Sep 17 00:00:00 2001
From: Yuxuan Shui
Date: Thu, 18 Jul 2024 16:07:45 +0100
Subject: [PATCH] [clangd] [IncludeCleaner] Use correct file ID
---
clang-tools-extra/
yshui wrote:
I can provide a repro if anyone is interested
https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yshui edited https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yshui edited https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yshui edited https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yshui edited https://github.com/llvm/llvm-project/pull/99514
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yshui created https://github.com/llvm/llvm-project/pull/99514
Unsure if this is the correct fix. But let me explain what I know so far about
this problem:
1. Include cleaner goes over macro refs, and calculates their source locations:
https://github.com/llvm/llvm-project
14 matches
Mail list logo
