[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate added a comment. > Thanks @aaron.ballman for the detailed explanation! I have learnt it. > @lygstate maybe include Aaron's explanation in commit message? The commit message is updated, is that ready for merge? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https:

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550587. lygstate added a comment. Revert to version 1 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index: clang/lib/Headers/bmiintrin.h

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate added a comment. In D157297#4590580 , @pengfei wrote: > > I'd prefer macro to duplicated definitions. We have such precedents, e.g., > https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994 Do you means revert to

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550413. lygstate added a comment. creating proper function definitions instead of macro define CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index: clang/lib/Head

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

lygstate added a comment. In D157297#4571572 , @pengfei wrote: > The description is not clear to me. You should describe the reason rather > than phenomenon. > > My understanding is double colon operator cannot resolve functions with > parentheses. http

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

lygstate created this revision. Herald added a project: All. lygstate requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Error message: In file included from ../src/amd/addrlib/src/core/addrobject.h:21: ../src/amd/addrlib/src/core/addrcommon.h