[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

yrouban added a comment. Looks good in general, but it would be better to have this patch split into several smaller patches: renaming NFC, InstructionCounter intro, one for each particular pass fix. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1057 + struct Inst

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban closed this revision. yrouban added a comment. Closed by commit https://reviews.llvm.org/rG7fb39fb6d6665cd469557b43eb205cc32b0a7ac3. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120713/new/ https://reviews.llvm.org/D120713 __

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban added subscribers: jhenderson, lattner. yrouban added a comment. In D120713#3353481 , @lattner wrote: > I'm not a competent reviewer for clangd > >> ! In D120713#3353532 , @jhenderson >> wrote: > > I don'

[PATCH] D120713: [clangd] Make dexp command line options sticky

yrouban created this revision. yrouban added reviewers: jhenderson, lattner, jpienaar, mehdi_amini. yrouban added a project: clang. Herald added subscribers: usaxena95, kadircet, arphaman. yrouban requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Hera

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39e3e3aa51d6: [NewPM] Redesign of PreserveCFG Checker (authored by yrouban). Changed prior to commit: https://reviews.llvm.org/D91327?vs=335221&id

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 335221. yrouban marked 2 inline comments as done. yrouban added a comment. Addressed comments. Some tests were moved a separate patch (D99878 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://revie

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added a comment. @skatkov, @fedor.sergeev, could you please review. During the long time this features is on the reconstruction we introduced a new bug in the LoopFlatten pass. See the comment https://reviews.llvm.org/D90940#inline-938253. CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422 + // Register all the standard instrumentation callbacks. If \p FAM is nullptr + // then PreservedCFGChecker is not registeredenabled. + void registerCallbacks(PassInstrumentatio

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 334042. yrouban added a comment. fixed the nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Passes/StandardInstrumentations.h llvm/lib/LTO

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban marked 2 inline comments as done. yrouban added a comment. In D91327#2655786 , @kuhar wrote: > Just two nits from me. I think it looks fine, but I'm not familiar with the > new pass manager and don't feel confident enough to approve it. Jakub, th

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 333825. yrouban added a comment. just rebased. please review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/CodeGen/BackendUtil.cpp llvm/include/llvm/Passes/StandardInstrumentations.h

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCFG; kuhar wrote: > yrouban wrote: > > kuhar wrote: > > > not necessary anymore > > there can bee a need to disabled/ena

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added a comment. In D91327#2408521 , @kuhar wrote: > Looks fine to me, but I'm not confident enough to give an approval. Thanks. I'm working closely with @skatkov and believe he have enough expertise to review fully. The biggest issue with the cu

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban added inline comments. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:134 public: static cl::opt VerifyPreservedCFG; kuhar wrote: > not necessary anymore there can bee a need to disabled/enable (e.g. for some tests or for debugging)

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban updated this revision to Diff 306604. yrouban marked 4 inline comments as done. yrouban edited the summary of this revision. yrouban added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91327/new/ https://reviews.llvm.org/D91327 Files: clang/lib/

[PATCH] D91327: [NewPM] Redesign of PreserveCFG Checker

yrouban created this revision. yrouban added reviewers: skatkov, kuhar, asbirlea, fedor.sergeev. Herald added subscribers: cfe-commits, wenlei, steven_wu, hiraditya. Herald added projects: clang, LLVM. yrouban requested review of this revision. Please see the reason for this redesign in the patch

[PATCH] D57220: Test fix for isViableInline remark message

yrouban closed this revision. yrouban added a comment. Landed along with D57089 (see rC352849 ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57220/new/ https://reviews.llvm.org/D57220

[PATCH] D57220: Test fix for isViableInline remark message

yrouban marked an inline comment as done. yrouban added inline comments. Comment at: test/Frontend/optimization-remark-with-hotness.c:63 // NO_PGO: '-fdiagnostics-hotness-threshold=' requires profile-guided optimization information // expected-remark@+1 {{foo inlined into

[PATCH] D57220: Test fix for isViableInline remark message

yrouban created this revision. yrouban added reviewers: xbolva00, anemet. Herald added a subscriber: cfe-commits. yrouban added a parent revision: D57089: Provide reason messages for unviable inlining. This patch adjusts the test remark message that is changed by D57089

[PATCH] D53428: Adjust cl::opt uses for opt_storage refactored

yrouban created this revision. yrouban added reviewers: chandlerc, rsmith, reames, skatkov. Herald added a subscriber: cfe-commits. This patch fixes compilation errors that result from refactoring of LLVM cl::opt structures introduced by https://reviews.llvm.org/D53426. Basically for class-based