[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

This revision was automatically updated to reflect the committed changes. Closed by commit rG10d78a06baa2: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 10d78a0 - [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

Author: Yaron Keren Date: 2021-08-31T18:57:47+03:00 New Revision: 10d78a06baa217b8a4b853eff962e9ae719a8a45 URL: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45 DIFF: https://github.com/llvm/llvm-project/commit/10d78a06baa217b8a4b853eff962e9ae719a8a45.diff

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren added a comment. Addressing comment in https://reviews.llvm.org/D108085 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109000/new/ https://reviews.llvm.org/D109000 ___ cfe-commits mailing list

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren marked an inline comment as done. yaron.keren added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# Windows: llvm-lit.py, Linux: llvm-lit +llvm_lit = glob.glob(os.path.join(config.llvm_tools_dir, 'llvm-lit*'))[0] +lit = config.l

[PATCH] D109000: [llvm-lit] unbreak clang-only builds by not assuming llvm-lit in build dir

yaron.keren created this revision. yaron.keren added a reviewer: tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109000 Files: clang/test/utils/update

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; vsapsai wrote: > yaron.keren wrote: > > Result is

[PATCH] D107690: [Modules] Do not remove failed modules after the control block phase

yaron.keren added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4268 // Read the AST block. if (ASTReadResult Result = ReadASTBlock(F, ClientLoadCapabilities)) + return Failure; Result is unused now. Comment

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa0f9cc9ab2: Use installed llvm-lit.py instead of lit.py PR-51072 (authored by yaron.keren). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ http

[clang] 5aa0f9c - Use installed llvm-lit.py instead of lit.py PR-51072

Author: Yaron Keren Date: 2021-08-18T09:06:06+03:00 New Revision: 5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb URL: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb DIFF: https://github.com/llvm/llvm-project/commit/5aa0f9cc9ab267803ad7bcfd14c8fd8bbffd82cb.diff

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366941. yaron.keren added a comment. Switched to Linux repo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: clang/test/utils/update_cc_test_checks/lit.lo

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren abandoned this revision. yaron.keren added a comment. opened by mistake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108218/new/ https://reviews.llvm.org/D108218 ___ cfe-commits mailing list

[PATCH] D108218: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D108218 Files: clang/test/utils/update_cc_test_checks/lit.local.cfg Index: c

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren updated this revision to Diff 366515. yaron.keren added a comment. Support both Windows llvm-lit.py and Linux llvm-lit command name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 Files: cla

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren added a comment. looking into Linux failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108085/new/ https://reviews.llvm.org/D108085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108085: Use installed llvm-lit.py instead of lit.py PR-51072

yaron.keren created this revision. yaron.keren added reviewers: Orlando, probinson, tstellar. yaron.keren requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Three tests fail when building and testing LLVM from the Visual C++ environment since

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG27e2ff964fc3: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace… (authored by yaron.keren). H

r336047 - Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there

Author: yrnkrn Date: Sat Jun 30 04:18:44 2018 New Revision: 336047 URL: http://llvm.org/viewvc/llvm-project?rev=336047&view=rev Log: Add expected fail triple x86_64-pc-windows-gnu to test as x86_64-w64-mingw32 is already there Modified: cfe/trunk/test/CodeGen/2007-06-18-SextAttrAggregate.c

r328447 - Remove reference to stale (2009) python version.

Author: yrnkrn Date: Sun Mar 25 06:12:05 2018 New Revision: 328447 URL: http://llvm.org/viewvc/llvm-project?rev=328447&view=rev Log: Remove reference to stale (2009) python version. Modified: cfe/trunk/www/hacking.html Modified: cfe/trunk/www/hacking.html URL: http://llvm.org/viewvc/llvm-p

Re: r305213 - Add regression test for r305179.

12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ > dblai...@gmail.com‬‏>:‬ > >> Prefer FileCheck over grep, generally? >> >> On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: yrnkrn

Re: r305213 - Add regression test for r305179.

Sure, r305215. ‫בתאריך יום ב׳, 12 ביוני 2017 ב-21:21 מאת ‪David Blaikie‬‏ <‪ dblai...@gmail.com‬‏>:‬ > Prefer FileCheck over grep, generally? > > On Mon, Jun 12, 2017 at 11:05 AM Yaron Keren via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: yr

r305215 - Address David Blaikie comment by replacing grep with FileCheck.

Author: yrnkrn Date: Mon Jun 12 13:29:37 2017 New Revision: 305215 URL: http://llvm.org/viewvc/llvm-project?rev=305215&view=rev Log: Address David Blaikie comment by replacing grep with FileCheck. Modified: cfe/trunk/test/Misc/pr32207.c Modified: cfe/trunk/test/Misc/pr32207.c URL: http://l

r305213 - Add regression test for r305179.

Author: yrnkrn Date: Mon Jun 12 13:05:13 2017 New Revision: 305213 URL: http://llvm.org/viewvc/llvm-project?rev=305213&view=rev Log: Add regression test for r305179. Added: cfe/trunk/test/Misc/pr32207.c Added: cfe/trunk/test/Misc/pr32207.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk

r304411 - Increase the limit for the number of DiagnosticLexKinds.td diags.

Author: yrnkrn Date: Thu Jun 1 07:46:59 2017 New Revision: 304411 URL: http://llvm.org/viewvc/llvm-project?rev=304411&view=rev Log: Increase the limit for the number of DiagnosticLexKinds.td diags. 300 was reached in r304190, 400 should be enough for a while. Modified: cfe/trunk/include/cla

Re: r304346 - [modules] When compiling a preprocessed module map, look for headers relative

Hi Richard, This broke the tests on the Windows bot: http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/5266 1. FAIL: Clang::preprocess-nested.cpp

Re: r301815 - Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC

out-of-tree code that uses WeakVH will continue to compile OK but may not perform OK with WeakVH not tracking anymore. May be better not to reuse WeakVH yet so such code will fail compilation. ‫בתאריך יום ב׳, 1 במאי 2017 ב-20:21 מאת ‪Sanjoy Das via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. OK https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. Raphael , do you have commit access? should I commit this? https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r301526 - Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC.

Author: yrnkrn Date: Thu Apr 27 04:56:39 2017 New Revision: 301526 URL: http://llvm.org/viewvc/llvm-project?rev=301526&view=rev Log: Constify SourceManager input to MacroInfo::getDefinitionLengthSlow, NFC. Modified: cfe/trunk/include/clang/Lex/MacroInfo.h cfe/trunk/lib/Lex/MacroInfo.cpp

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/list

[PATCH] D32486: Cleanup pragma handlers after DoPrintPreprocessedInput

yaron.keren added a comment. Please move the =new out of the PP.AddPragmaHandler calls. While at it, this code still (as the original) leaks the PragmaHandlers. These should be deleted after RemovePragmaHandler or instead, simply use std::unique_ptr. https://reviews.llvm.org/D32486

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren reopened this revision. yaron.keren added a comment. reverted in r300497 Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions

3:32: note: previous definition is here > template inline void f() {} > > > I reverted this change in r300497. > > On Mon, Apr 17, 2017 at 10:51 AM, Yaron Keren via cfe-commits > wrote: > > Author: yrnkrn > > Date: Mon Apr 17 03:51:20 2017 > > New Revision

r300443 - Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse, and definitions are

Author: yrnkrn Date: Mon Apr 17 03:51:20 2017 New Revision: 300443 URL: http://llvm.org/viewvc/llvm-project?rev=300443&view=rev Log: Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice

r300423 - Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard.

Author: yrnkrn Date: Sun Apr 16 10:53:19 2017 New Revision: 300423 URL: http://llvm.org/viewvc/llvm-project?rev=300423&view=rev Log: Use setUsedForHeaderGuard() accessor function instead of direcly accessing UsedForHeaderGuard. Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/tru

[PATCH] D15006: Driver: Better detection of mingw-gcc

yaron.keren added reviewers: mati865, rnk. yaron.keren added a comment. Adding Mateusz and Reid. Repository: rL LLVM https://reviews.llvm.org/D15006 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren updated this revision to Diff 94961. yaron.keren added a comment. Added attribute test. https://reviews.llvm.org/D31540 Files: tools/clang/include/clang/AST/DeclBase.h tools/clang/lib/AST/Decl.cpp tools/clang/lib/AST/DeclBase.cpp tools/clang/test/SemaTemplate/friend-template

r300043 - Rangify for loop, NFC.

Author: yrnkrn Date: Wed Apr 12 05:05:48 2017 New Revision: 300043 URL: http://llvm.org/viewvc/llvm-project?rev=300043&view=rev Log: Rangify for loop, NFC. Modified: cfe/trunk/lib/Sema/SemaLookup.cpp Modified: cfe/trunk/lib/Sema/SemaLookup.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/tr

r300036 - Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436.

Author: yrnkrn Date: Wed Apr 12 03:17:44 2017 New Revision: 300036 URL: http://llvm.org/viewvc/llvm-project?rev=300036&view=rev Log: Remove Sema::addOverloadedOperatorToUnresolvedSet declaration. Its definition was removed in r206436. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified:

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren added a comment. Thanks, I'll make a test. Repository: rL LLVM https://reviews.llvm.org/D31540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

yaron.keren added inline comments. Comment at: cmake/modules/HandleLLVMOptions.cmake:562 add_flag_if_supported("-Wstring-conversion" STRING_CONVERSION_FLAG) +else() + append("-w" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) note this is an else to if (LLVM_ENABLE_WARNINGS

[PATCH] D31540: Prefer non-friend to friend in in redeclaration chain

yaron.keren created this revision. Address http://bugs.llvm.org/pr30994 so that a non-friend can properly replace a friend, and a visible friend can properly replace an invisible friend but not vice verse. This also fixes two FIXME in SemaTemplate/friend-template.cpp. Repository: rL LLVM ht

Re: r299079 - Move NumRegParameters Module Flag. NFCI.

Thanks! If you like, might make sense now to move all these addModuleFlag() into a new helper function, addModuleFlags(). ‫בתאריך יום ה׳, 30 במרץ 2017 ב-16:54 מאת ‪Nirav Dave via cfe-commits‬‏ <‪ cfe-commits@lists.llvm.org‬‏>:‬ > Author: niravd > Date: Thu Mar 30 08:41:44 2017 > New Revision: 29

[PATCH] D31187: Fix removal of out-of-line definitions.

yaron.keren added a comment. Could use dumpDeclContext() to test? https://reviews.llvm.org/D31187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r295839 - Remove superfluous initializer.

Author: yrnkrn Date: Wed Feb 22 08:32:39 2017 New Revision: 295839 URL: http://llvm.org/viewvc/llvm-project?rev=295839&view=rev Log: Remove superfluous initializer. The following fully-covered switch either sets value to External or exits the function. Modified: cfe/trunk/lib/AST/ASTContex

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. OK. https://reviews.llvm.org/D29464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. If something is broken now we don't break it even more. __float128 remain be fixed to be compatible, not only some poor developer would have to fix the missing headers bug one day, he will have to re-fix limits.h the right way and undo this "fix". There is a problems

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. These directories are "mostly" equivalent, with some headers existing is mings gcc dir but missing in clang resource dir and thus will break compilation. For example, the most popular (37089 download this week) https://sourceforge.net/projects/mingw-w64 distribuion f

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. What about omp.h and openacc.h ? many programs are using OpenMP. You raised real issues which should certainly be solved with clang mingw support. Removing the gcc dirs from include path will break any program that currently uses or depends in any way on any header

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. The gcc include dirs in mingw contains headers not available esewhere and thus can't be removed. Notable examples, omp.h - OpenMP functions openacc.h - OpenACC functions quadmath.h - QUADMATH functions https://reviews.llvm.org/D29464 __

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. Hiding these two include dirs removes many headers. Most has clang equivalents but not all of them. For example quadmath.h is only there, and without the include path programs using it will fail to compile. The reason mingw limits.h isn't used in your example is tha

[PATCH] D29464: [MinGWToolChain] Don't use GCC headers on Win32

yaron.keren added a comment. This code is actually used with Windows as well as Linux (with the exception of line 218), see the comment blocks above for detailed include dirs from all platforms from which it was derived. Please make sure include dirs between gcc and clang match after the patch

[PATCH] D28620: Guard __gnuc_va_list typedef

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM, matches the code in libstdc++ stdarg,h. You can remove the 'hack' comment in line 46, __GNUC_VA_LIST is just a standard include guard for the typedef. https://reviews.llvm.or

r292032 - Fix PR31644 introduced by r287138 and add a regression test.

Author: yrnkrn Date: Sat Jan 14 15:12:08 2017 New Revision: 292032 URL: http://llvm.org/viewvc/llvm-project?rev=292032&view=rev Log: Fix PR31644 introduced by r287138 and add a regression test. Thanks Dimitry Andric for the report and fix! Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

yaron.keren added a comment. In https://reviews.llvm.org/D28399#642458, @v.g.vassilev wrote: > @yaron.keren, it seems that http://llvm.org/pr30994 concerns friend function > declarations. My current patch focuses on friend class templates. Perhaps we > should open another review item for a fix

[PATCH] D28399: PR31469: Don't add friend template class decls to redecl chain in dependent contexts.

yaron.keren added a comment. While at it, llvm.org/pr30994 Repository: rL LLVM https://reviews.llvm.org/D28399 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r291230 - Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC.

Author: yrnkrn Date: Fri Jan 6 05:15:57 2017 New Revision: 291230 URL: http://llvm.org/viewvc/llvm-project?rev=291230&view=rev Log: Constify UsingPackDecl::getInstantiatedFromUsingDecl(), NFC. Modified: cfe/trunk/include/clang/AST/DeclCXX.h Modified: cfe/trunk/include/clang/AST/DeclCXX.h U

[PATCH] D27810: Normalize all filenames before searching FileManager caches

yaron.keren added inline comments. Comment at: lib/Basic/FileManager.cpp:218 +#ifdef LLVM_ON_WIN32 + SmallString<128> NormalizedPath(Filename.str()); + llvm::sys::path::native(NormalizedPath); I'd use a larger SmallString<256>, with large projects 128 bytes are

r290495 - Deduplicate several GD.getDecl() calls into Decl * local variable.

Author: yrnkrn Date: Sat Dec 24 09:32:39 2016 New Revision: 290495 URL: http://llvm.org/viewvc/llvm-project?rev=290495&view=rev Log: Deduplicate several GD.getDecl() calls into Decl * local variable. Modified: cfe/trunk/lib/CodeGen/CodeGenModule.cpp Modified: cfe/trunk/lib/CodeGen/CodeGenMo

r289328 - Simplify parseShowColorsArgs logic, NFC.

Author: yrnkrn Date: Sat Dec 10 08:55:14 2016 New Revision: 289328 URL: http://llvm.org/viewvc/llvm-project?rev=289328&view=rev Log: Simplify parseShowColorsArgs logic, NFC. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL:

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

yaron.keren accepted this revision. yaron.keren added a comment. This revision is now accepted and ready to land. LGTM after fixing the inline comment Comment at: lib/Serialization/ASTReader.cpp:5804 QualType ElementType = readType(*Loc.F, Record, Idx); -return Context

r288124 - Correct comment: we are creating a canonicla decltypetype.

Author: yrnkrn Date: Tue Nov 29 04:08:20 2016 New Revision: 288124 URL: http://llvm.org/viewvc/llvm-project?rev=288124&view=rev Log: Correct comment: we are creating a canonicla decltypetype. Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://

[PATCH] D27049: [OpenCL] Refactor out ReadPipe/WritePipe

yaron.keren added inline comments. Comment at: lib/AST/ASTContext.cpp:8258 return RHS; -return isa(LHS) ? getReadPipeType(ResultType) - : getWritePipeType(ResultType); +const PipeType *PT = LHS->getAs(); +return PT->isReadOnly()

Re: r287343 - [OpenCL] Introduce ReadPipeType and WritePipeType.

Hi Joey, In order for ReadPipeType and WritePipeType to work with LLVM type system (isa, dyn_cast), you need to modify the existing TypeClass::Pipe kind into TypeClass::ReadPipe and TypeClass::WritePipe, have Pipe::classof recognize both kinds and have ReadPipe::classof and WritePipe::classof rec

r287138 - Rangify for loops, NFC.

Author: yrnkrn Date: Wed Nov 16 13:24:10 2016 New Revision: 287138 URL: http://llvm.org/viewvc/llvm-project?rev=287138&view=rev Log: Rangify for loops, NFC. Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp Modified: cfe/trunk/lib/Frontend/DependencyFile.cpp URL: http://llvm.org/viewvc/l

r287102 - Rangify for loop, NFC.

Author: yrnkrn Date: Wed Nov 16 07:45:34 2016 New Revision: 287102 URL: http://llvm.org/viewvc/llvm-project?rev=287102&view=rev Log: Rangify for loop, NFC. Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL: http://llvm.org/viewvc/llvm-project/c

Re: r285258 - Refactor call emission to package the function pointer together with

Hi John, clang warns on this: /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:79:7: warning: anonymous types declared in an anonymous union are an extension [-Wnested-anon-types] struct { ^ /llvm/tools/zapccs/../clang/include/../lib/CodeGen/CGCall.h:83:7: warning: anonymou

r283657 - Un-tabify source files, NFC.

Author: yrnkrn Date: Sat Oct 8 01:45:10 2016 New Revision: 283657 URL: http://llvm.org/viewvc/llvm-project?rev=283657&view=rev Log: Un-tabify source files, NFC. Modified: cfe/trunk/lib/AST/ASTContext.cpp cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/AST/NestedNameSpecifier.cpp

Re: r283063 - Alias must point to a definition

yes, it works, thanks! 2016-10-03 18:19 GMT+03:00 Aditya K : > Thanks for poining that out. I have updated the test case, please see if > that works. > > > http://llvm.org/viewvc/llvm-project?view=revision&revision=283085 > > > > -Aditya > > > ----

Re: r283063 - Alias must point to a definition

The mangling is different when targeting MSVC ABI, see failure at http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/29889/steps/test_all/logs/Clang%20%3A%3A%20CodeGenCXX__alias-available-externally.cpp maybe -triple x86_64-pc-linux ? 2016-10-02 6:06 GMT+03:00 Aditya Kumar via cfe-com

Re: [PATCH] D24754: [cleanup] Remove excessive padding from RedeclarableResult

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. also, gcc warns if order of field initializators is different than the order of fields. Repository: rL LLVM https://reviews.llvm.org/D24754 ___ cfe-commits mailing list cf

Re: r278984 - Add test missed from r278983.

Thanks! 2016-08-25 0:39 GMT+03:00 Richard Smith : > As of r279668, we shouldn't run this test for ASan builds any more. > Perhaps we should increase Clang's minimum stack allocation when built with > ASan to compensate for it making stack frames larger. > On Wed, Aug 24, 2

Re: r278984 - Add test missed from r278983.

I see the same stack overflow asan error in a local buildbot. 2016-08-22 20:30 GMT+03:00 Akira Hatanaka via cfe-commits < cfe-commits@lists.llvm.org>: > Hi Richard, > > This test has been failing since it was committed. > > http://lab.llvm.org:8080/green/job/clang-stage2-cmake-RgSan_check/2277/

r277334 - Allow .exe extension to ld to fix test with mingw.

Author: yrnkrn Date: Mon Aug 1 05:14:54 2016 New Revision: 277334 URL: http://llvm.org/viewvc/llvm-project?rev=277334&view=rev Log: Allow .exe extension to ld to fix test with mingw. Modified: cfe/trunk/test/Driver/offloading-interoperability.c Modified: cfe/trunk/test/Driver/offloading-in

r276252 - Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions.

Author: yrnkrn Date: Thu Jul 21 02:44:41 2016 New Revision: 276252 URL: http://llvm.org/viewvc/llvm-project?rev=276252&view=rev Log: Provide __GLIBCXX_TYPE_INT_N_0 and __GLIBCXX_BITSIZE_INT_N_0 when in C++ gnu language extensions. These are used by libstdc++ for is_integral<__int128>. Addresses

r275303 - Implement FunctionDecl::getDefinition() to be consistent with

Author: yrnkrn Date: Wed Jul 13 14:04:51 2016 New Revision: 275303 URL: http://llvm.org/viewvc/llvm-project?rev=275303&view=rev Log: Implement FunctionDecl::getDefinition() to be consistent with VarDecl, TagDecl, EnumDecl, RecordDecl, CXXRecordDecl. Use getDefinition in two locations to make the

Re: r274257 - Don't instantiate a full host toolchain in ASTMatchersTest.

Seems this commit broke a builder, http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26133 http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/26134 TEST 'Clang-Unit :: ASTMatchers/ASTMatchersTests/Declaratio

r274149 - Add CapturedDecl::parameters() ArrayRef accessors following r273647.

Author: yrnkrn Date: Wed Jun 29 13:55:53 2016 New Revision: 274149 URL: http://llvm.org/viewvc/llvm-project?rev=274149&view=rev Log: Add CapturedDecl::parameters() ArrayRef accessors following r273647. Modified: cfe/trunk/include/clang/AST/Decl.h Modified: cfe/trunk/include/clang/AST/Decl.h

Re: [PATCH] D21117: Specify target in lifetime-asan test.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. You mean Some target platforms do not support -fsanitize=address. http://reviews.llvm.org/D21

Re: r271399 - It seems we need to add SemaExpr.cpp to the /bigobj list; I am getting consistent failures of hitting the section count limit.

Thanks! I've just noticed this today locally. It happens with unoptimized builds only so the bots are not catching it. 2016-06-01 18:17 GMT+03:00 Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org>: > Author: aaronballman > Date: Wed Jun 1 10:17:54 2016 > New Revision: 271399 > > URL:

r271392 - Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build.

Author: yrnkrn Date: Wed Jun 1 08:47:26 2016 New Revision: 271392 URL: http://llvm.org/viewvc/llvm-project?rev=271392&view=rev Log: Fix the CLANG_ENABLE_STATIC_ANALYZER=OFF build. tools/clang/tools/CMakeLists.txt does not create the clang-check target when CLANG_ENABLE_STATIC_ANALYZER=OFF. Mod

r269801 - Teach clang to look for libcxx in /usr/local/include/c++ on Linux

Author: yrnkrn Date: Tue May 17 14:01:16 2016 New Revision: 269801 URL: http://llvm.org/viewvc/llvm-project?rev=269801&view=rev Log: Teach clang to look for libcxx in /usr/local/include/c++ on Linux As The default CMAKE install prefix is /usr/local ( https://cmake.org/cmake/help/v3.0/variable/CM

Re: [PATCH] D20240: [clang-rename] Fix broken dependency on shared build.

yaron.keren added a subscriber: yaron.keren. yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. result of r269402, LGTM http://reviews.llvm.org/D20240 ___

r269423 - Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h

Author: yrnkrn Date: Fri May 13 09:53:19 2016 New Revision: 269423 URL: http://llvm.org/viewvc/llvm-project?rev=269423&view=rev Log: Prune four superfluous ExternalSemaSource.h includes and one forward declaration in Sema.h where ExternalSemaSource.h was already included due to ExternalSemaSource

Re: r268797 - Fix sysroot-prefix.c on Windows (/ vs \).

Hi Nico, In other tests, {{/|}} or {{/|\\}} are used match the forward or backward slash(es). clang escapes \ so we get two of them in output and four in the LIT test. It would be nice to have more elegant construct for this general problem, to avoid tests like: "{{.*}}/Inputs/mingw_mingw_or

Re: r259734 - Fix predefine for __NSConstantString struct type

If used only for Darwin, could this depend on Target.getTriple().isOSDarwin() ? 2016-04-11 17:18 GMT+03:00 Ben Langmuir : > > On Apr 3, 2016, at 10:57 AM, Yaron Keren wrote: > > I look at many AST dumps for small reduced code so it's mostly weird to > see this in the AST

Re: r259734 - Fix predefine for __NSConstantString struct type

> “weird” to see it in the AST? > > On Apr 3, 2016, at 5:21 AM, Yaron Keren wrote: > > +1, if possible. There is a if (getLangOpts().ObjC1) block just before > this. > > 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits < > cfe-commits@lists.llvm.org>:

Re: r259734 - Fix predefine for __NSConstantString struct type

+1, if possible. There is a if (getLangOpts().ObjC1) block just before this. 2016-04-03 14:21 GMT+03:00 Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org>: > On 04/02/16 01:55, Ben Langmuir via cfe-commits wrote: > >> Author: benlangmuir >> Date: Wed Feb 3 18:55:24 2016 >> New Revisio

r263635 - Directly get the canonical Type instead of going around through a CanQualType temporary, NFC.

Author: yrnkrn Date: Wed Mar 16 07:14:43 2016 New Revision: 263635 URL: http://llvm.org/viewvc/llvm-project?rev=263635&view=rev Log: Directly get the canonical Type instead of going around through a CanQualType temporary, NFC. Modified: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp Modified: cfe

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren accepted this revision. yaron.keren added a reviewer: yaron.keren. yaron.keren added a comment. This revision is now accepted and ready to land. Would be nice to have CodeGenAction::TheModule redirect to CodeGeneratorImpl::M if possible, but that's for another patch. LGTM. http://re

Re: [PATCH] D15450: Avoid double deletion in Clang driver.

yaron.keren added a comment. It certainly makes sense to redirect the module request to its owner instead of duplicating it in a local copy. There may be a change in behaviour here, pre-patch CodeGenAction::EndSourceFileAction() would take the BackendConsumer Module, keeping CodeGen Module int

Re: [PATCH] D17183: Make TargetInfo store an actual DataLayout instead of a string.

yaron.keren added a subscriber: yaron.keren. yaron.keren added a comment. We have tried to keep one copy of http://reviews.llvm.org/D11103 Can it share the Module->getDataLayout() ? http://reviews.llvm.org/D17183 ___ cfe-commits mailing list cfe-com

r260028 - Use CodeGenModule::addReplacement() instead of directly accessing Replacements[].

Author: yrnkrn Date: Sun Feb 7 06:44:35 2016 New Revision: 260028 URL: http://llvm.org/viewvc/llvm-project?rev=260028&view=rev Log: Use CodeGenModule::addReplacement() instead of directly accessing Replacements[]. This helps when trying to debug who inserted into Replacements. Modified: cf

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Committed clang part in r259232, LLVM part in r259240. 2016-01-29 21:22 GMT+02:00 Richard Smith : > On Fri, Jan 29, 2016 at 11:13 AM, Yaron Keren > wrote: > > OK. There are more un-annotated dump() methods such as > > TemplateName::dump(), NestedNameSpecifier::dump(

r259232 - Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment.

Author: yrnkrn Date: Fri Jan 29 13:38:18 2016 New Revision: 259232 URL: http://llvm.org/viewvc/llvm-project?rev=259232&view=rev Log: Annotate dump() methods with LLVM_DUMP_METHOD, addressing Richard Smith r259192 post commit comment. Modified: cfe/trunk/lib/AST/APValue.cpp cfe/trunk/lib

Re: r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

OK. There are more un-annotated dump() methods such as TemplateName::dump(), NestedNameSpecifier::dump(), ASTReader::dump(), ModuleMap::dump(), MacroInfo::dump(), ... Annotate all dump() methods LLVM_DUMP_METHOD ? 2016-01-29 19:37 GMT+02:00 Richard Smith : > On 29 Jan 2016 5:50 a.m., &qu

r259192 - Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump().

Author: yrnkrn Date: Fri Jan 29 07:46:15 2016 New Revision: 259192 URL: http://llvm.org/viewvc/llvm-project?rev=259192&view=rev Log: Implement TemplateArgument::dump() method for debugging, patterned after TemplateName::dump(). Modified: cfe/trunk/include/clang/AST/TemplateBase.h cfe/tr

Re: [PATCH] D16478: Always build a new TypeSourceInfo for function templates with parameters

The instantiated does get a new collection of ParmVarDecls while getting the pattern Type which points to the pattern ParmVarDecls. So the ParmVarDecls pointed in the instantiated are not the same as those pointed by its Type. Traversing by Type or by the Decl finds a different set of ParmVarDecls

Re: [PATCH][Modules][PR26179]

Committed revision 258524. 2016-01-21 19:33 GMT+02:00 Vassil Vassilev via cfe-commits < cfe-commits@lists.llvm.org>: > ping... (perhaps someone else with commit rights can check it it...) > --Vassil > > On 18/01/16 22:07, Vassil Vassilev wrote: > > Thanks! Could you check it in? > -- Vassil > On

r258524 - Merge templated static member variables, fixes http://llvm.org/pr26179.

Author: yrnkrn Date: Fri Jan 22 13:03:27 2016 New Revision: 258524 URL: http://llvm.org/viewvc/llvm-project?rev=258524&view=rev Log: Merge templated static member variables, fixes http://llvm.org/pr26179. Patch by Vassil Vassilev! Reviewed by Richard Smith. Added: cfe/trunk/test/Modules/Inp

r256472 - Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger.

Author: yrnkrn Date: Sun Dec 27 08:34:22 2015 New Revision: 256472 URL: http://llvm.org/viewvc/llvm-project?rev=256472&view=rev Log: Constify NestedNameSpecifier::dump and add a no-argument dump function suitable for calling from a debugger. Modified: cfe/trunk/include/clang/AST/NestedNameS

  1   2   >