[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya added a comment. Hi, @Anastasia. Please help to land it, thanks very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 ___ cfe-commits mailing list

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya updated this revision to Diff 407506. haonanya added a comment. Remove the .td changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119398/new/ https://reviews.llvm.org/D119398 Files: clang/lib/Headers/opencl-c.h Index: clang/lib/He

[PATCH] D119398: [OpenCL] Guard atomic_double with cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics

haonanya created this revision. haonanya added reviewers: Anastasia, svenvh. haonanya added a project: clang. Herald added subscribers: Naghasan, ldrumm, yaxunl. haonanya requested review of this revision. Herald added a subscriber: cfe-commits. It is necessary to guard atomic_double type accordin

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

haonanya added a comment. Hi, svenvh. Thanks for your review. Could you please help to submit the patch if there are no more inputs? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 ___ cfe-commits ma

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

haonanya updated this revision to Diff 376467. haonanya added a comment. Fix format issue CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109740/new/ https://reviews.llvm.org/D109740 Files: clang/lib/Headers/opencl-c.h clang/lib/Sema/OpenCLBuiltins.td clang/lib/Sema/Sema.cpp clan

[PATCH] D106778: [OpenCL] opencl-c.h: add CL 3.0 non-generic address space atomics

haonanya added inline comments. Comment at: clang/lib/Headers/opencl-c.h:13379 +uint __ovld atomic_fetch_xor(volatile __global atomic_uint *object, uint operand); +uint __ovld atomic_fetch_xor(volatile __local atomic_uint *object, uint operand);i +int __ovld atomic_fetch_and(vo

[PATCH] D109740: [OpenCL] Add atomic_half type builtins

haonanya created this revision. haonanya added reviewers: svenvh, Anastasia. haonanya added a project: clang. Herald added subscribers: ldrumm, yaxunl. haonanya requested review of this revision. Herald added a subscriber: cfe-commits. Add atomic_half types and builtins operating on the types Re

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh. I am ok with the patch. Thanks very much. I'd appreciate it if you help review https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/1116 as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Kindly ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. In D106343#2967089 , @haonanya wrote: > Hi, svenvh. > Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to > guard the functions using atomic_double type? > Thanks very much. > > #if defined(__opencl

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh and Anastasia. If you approve the patch, could you please submit it? I don't have permission to do it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ cfe-com

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, svenvh. Should we use cl_khr_int64_base_atomics and cl_khr_int64_extended_atomics to guard the functions using atomic_double type? Thanks very much. #if defined(__opencl_c_ext_fp64_local_atomic_min_max) double __ovld atomic_fetch_min(volatile __local atomic_dou

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. In D106343#2892946 , @Anastasia wrote: > The extension spec seems to also mention `atomic_half`. Are planning to add > it too? Hi, Anastasia. I also have some work to translate these atomic builtins on SPIRV currently, so I'd

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 368256. haonanya added a comment. Fix formatting issues CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h clang/lib/Sema/OpenCLBui

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 368119. haonanya added a comment. Unify formatting and fix some errors on OpenCLBuiltins.td CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/o

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 367980. haonanya added a comment. Let builtins are guarded by related macro CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/opencl-c.h clan

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 367178. haonanya added a comment. Remove OpenCL3.0 macro guards on opencl-c.h and OpenCLBuiltins.td. Add missing feature macro. simplify test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clan

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya added a comment. Hi, Anastasia and svenvh. Sorry for late reply. I have updated patch per your comments. Many thanks for your comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 ___ c

[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

haonanya updated this revision to Diff 366829. haonanya added a comment. Add the new builtins to clang/lib/Sema/OpenCLBuiltins.td. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106343/new/ https://reviews.llvm.org/D106343 Files: clang/lib/Headers/opencl-c-base.h clang/lib/Headers/o