simonzgx wrote:
Hi @erichkeane , can this patch be merged? Or if there is anything else I need
to do, please let me know.
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
simonzgx wrote:
> You seem to have lost the tests in the latest version of this commit.
Have already added.
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/simonzgx deleted
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 54b69712d2ffc3536d41d56194e67da802b92049 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/5] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
@@ -1997,9 +1997,12 @@ def Convergent : InheritableAttr {
def NoInline : DeclOrStmtAttr {
let Spellings = [CustomKeyword<"__noinline__">, GCC<"noinline">,
CXX11<"clang", "noinline">, C23<"clang", "noinline">,
+ CXX11<"msvc", "noinline">, C
@@ -0,0 +1,72 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s -Wno-c++17-extensions
simonzgx wrote:
I removed the redundant unit tests, but no new test cases were added. I'm not
sure if that's acceptable, because `[[msvc::noinline]]` is just an alias for
`[[cla
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 54b69712d2ffc3536d41d56194e67da802b92049 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/4] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/simonzgx deleted
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,72 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s -Wno-c++17-extensions
simonzgx wrote:
`[[msvc::noinline]]` is just an alias of `[[clang::noinline]]`, and maybe we
don't really need UT for it, so I just deleted the redundant test files. What
do you
https://github.com/simonzgx deleted
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1997,9 +1997,12 @@ def Convergent : InheritableAttr {
def NoInline : DeclOrStmtAttr {
let Spellings = [CustomKeyword<"__noinline__">, GCC<"noinline">,
CXX11<"clang", "noinline">, C23<"clang", "noinline">,
+ CXX11<"msvc", "noinline">, C
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 54b69712d2ffc3536d41d56194e67da802b92049 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/4] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 54b69712d2ffc3536d41d56194e67da802b92049 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/3] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
@@ -1997,9 +1997,12 @@ def Convergent : InheritableAttr {
def NoInline : DeclOrStmtAttr {
let Spellings = [CustomKeyword<"__noinline__">, GCC<"noinline">,
CXX11<"clang", "noinline">, C23<"clang", "noinline">,
+ CXX11<"msvc", "noinline">, C
@@ -1997,9 +1997,12 @@ def Convergent : InheritableAttr {
def NoInline : DeclOrStmtAttr {
let Spellings = [CustomKeyword<"__noinline__">, GCC<"noinline">,
CXX11<"clang", "noinline">, C23<"clang", "noinline">,
+ CXX11<"msvc", "noinline">, C
@@ -0,0 +1,72 @@
+// RUN: %clang_cc1 -verify -fsyntax-only %s -Wno-c++17-extensions
simonzgx wrote:
Okay, will fix.
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
simonzgx wrote:
Hi @cor3ntin , this is just a gentle reminder to confirm if it is still
convenient for you to review this patch, or if you could assist in inviting
other appropriate reviewers? Thank you.
https://github.com/llvm/llvm-project/pull/91720
__
simonzgx wrote:
Hi @cor3ntin, could you please help review this patch?
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx edited
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx ready_for_review
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx edited
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 2dd3d3385642d88d538bc37673018f1231a56b14 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/3] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From 2dd3d3385642d88d538bc37673018f1231a56b14 Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/simonzgx updated
https://github.com/llvm/llvm-project/pull/91720
>From d0cde98f5e933c6f88703a55986f6cc508721fdc Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90941)
https://github.com/simonzgx converted_to_draft
https://github.com/llvm/llvm-project/pull/91720
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/simonzgx created
https://github.com/llvm/llvm-project/pull/91720
None
>From d0cde98f5e933c6f88703a55986f6cc508721fdc Mon Sep 17 00:00:00 2001
From: Xu Zhang
Date: Fri, 10 May 2024 01:24:24 +0800
Subject: [PATCH 1/2] [Clang] Add support for [[msvc::noinline]] attribute.
(#90
26 matches
Mail list logo
