Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-08-20 Thread WuZhao via cfe-commits
WuZhao added a comment. I wan to point to some issues, because I am also doing AIX support based on your patch and I tested and verified. Firstly, in the lib/Driver/ToolChains.cpp line 3756 case llvm::Triple::ppc64: addPathIfExists(D, getDriver().SysRoot + getDriver().Dir + "/../lib64",

Re: [PATCH] D18360: Add AIX Target/ToolChain to Clang Driver

2016-05-23 Thread WuZhao via cfe-commits
WuZhao added a subscriber: WuZhao. WuZhao added a comment. Hi , I find one mistake in the lib/Basic/Targets.cpp. On my AIX 7.1 machine /usr/include/sys/inttypes.h, 64 bits wchar_t is unsigned int, not signed int. #ifndef _WCHAR_T #define _WCHAR_T #ifdef __64BIT__ typedef unsigned int