[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-10-09 Thread William Woodruff via Phabricator via cfe-commits
woodruffw updated this revision to Diff 378476. woodruffw added a comment. Resolve conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp clang/test/AST/

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-09-29 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Another gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-09-14 Thread William Woodruff via Phabricator via cfe-commits
woodruffw updated this revision to Diff 372595. woodruffw added a comment. Increase the context for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 Files: clang/lib/Frontend/ASTConsumers.cpp

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-09-08 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Another gentle ping for review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-08-30 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Gentle ping for review on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108441/new/ https://reviews.llvm.org/D108441 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-08-20 Thread William Woodruff via Phabricator via cfe-commits
woodruffw updated this revision to Diff 367938. woodruffw added a comment. Updated the AST dump tests for JSON to refute the presence of the `Dumping ` prefix. Also, updated the `gen_ast_dump_json_test.py` generator to work with Python 3 and to behave better without the presence of the `Dumping

[PATCH] D108441: [clang] Fix JSON AST output when a filter is used

2021-08-19 Thread William Woodruff via Phabricator via cfe-commits
woodruffw created this revision. woodruffw added reviewers: klimek, rsmith. woodruffw added a project: clang. woodruffw requested review of this revision. Herald added a subscriber: cfe-commits. Without this, the combination of `-ast-dump=json` and `-ast-dump-filter FILTER` produces invalid JSON:

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

2019-06-28 Thread William Woodruff via Phabricator via cfe-commits
woodruffw added a comment. Yep, I'll add one in a bit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63697/new/ https://reviews.llvm.org/D63697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D63697: clang-format: Fix error return when using inplace with stdin

2019-06-23 Thread William Woodruff via Phabricator via cfe-commits
woodruffw created this revision. woodruffw added reviewers: clang, thakis. woodruffw added a project: clang. Herald added a subscriber: cfe-commits. Causes clang-format to exit with an appropriate error code when the invalid combination of -i and stdin is provided. Repository: rC Clang https: