r345258 - [ms] Prevent explicit constructor name lookup if scope is missing

2018-10-25 Thread Will Wilson via cfe-commits
Author: lantictac Date: Thu Oct 25 04:45:32 2018 New Revision: 345258 URL: http://llvm.org/viewvc/llvm-project?rev=345258&view=rev Log: [ms] Prevent explicit constructor name lookup if scope is missing MicrosoftExt allows explicit constructor calls. Prevent lookup of constructor name unless the

Re: [PATCH] D22955: [MSVC] Improved late parsing of template functions.

2016-11-16 Thread Will Wilson via cfe-commits
A backup ping. Sorry for the noise but this would be a very useful patch to get done and dusted. On 10 November 2016 at 08:17, Alexey Bataev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > ABataev added a comment. > > Ping > > > https://reviews.llvm.org/D22955 > > > > _

Re: [PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-30 Thread Will Wilson via cfe-commits
Hi Alexey, On 31 May 2016 at 12:25, Alexey Bataev wrote: > Hi Will, > Thanks for the report and sorry for a delay with answer. Generally, your > patch looks good with some small nits. I can fix some minor issues like > extra braces etc. and commit it if you don't mind. > Sure thing. Commit away

[PATCH] Fix stack overflow in MSVC unqualified type lookup logic

2016-05-27 Thread Will Wilson via cfe-commits
Hi Alexey, A customer encountered a stack overflow in the code from r229817. I've created a small repro for testing the issue and a fix. The fix should also better deal with lookup into partially specialized base templates. Test case included and tested against latest trunk. Let me know if it lo

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
n Tue, Oct 27, 2015 at 7:49 AM, Will Wilson via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I've ended up using the simplified fix described on the MS connect bug >> report for this issue: >> >> https://connect.microsoft.com/VisualStudio/feedba

r251415 - [MSVC] Workaround for ICE in cl.exe when compiling ASTContext.cpp in Release Win32

2015-10-27 Thread Will Wilson via cfe-commits
Author: lantictac Date: Tue Oct 27 12:01:10 2015 New Revision: 251415 URL: http://llvm.org/viewvc/llvm-project?rev=251415&view=rev Log: [MSVC] Workaround for ICE in cl.exe when compiling ASTContext.cpp in Release Win32 Microsoft connect bug: https://connect.microsoft.com/VisualStudio/feedback/d

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
I've ended up using the simplified fix described on the MS connect bug report for this issue: https://connect.microsoft.com/VisualStudio/feedback/details/1741530 I’ve been able to work around this by changing ASTContext.cpp:368 from if (RC) { Raw.setRaw(RC); Raw.setKind(RawCommentAndCach

Re: [PATCH] D13203: [Clang] - Massaging code to fix MSVS 2015 win32-release configuration

2015-10-27 Thread Will Wilson via cfe-commits
Building latest HEAD using: cmake -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DLLVM_USE_CRT_RELWITHDEBINFO=MT -DLLVM_BUILD_TOOLS=OFF -DLLVM_INCLUDE_EXAMPLES=OFF -DLLVM_ENABLE_ASSERTIONS=OFF LLVM_BUILD_32_BITS=ON ..\llvm VC++ version: Microsoft (R) C/C++ Optimizing Compiler Version 19.00.23026 fo