[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

2018-01-11 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Ping! Is this stalling on reviewer attention? If so, please submit to LLVM Weekly's review corner (assuming it works with current LLVM), see http://llvmweekly.org/reviewcorner for details. Repository: rL LLVM https://reviews.llvm.org/D28462 __

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-12-08 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Okay, that makes sense. Thanks for accommodating my use-case anyway! :D. Repository: rL LLVM https://reviews.llvm.org/D40685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D40685: [libunwind] Switch to add_llvm_install_targets

2017-12-08 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Hmm, this change means very recent LLVM is required to build libunwind-- previously I was able to use recent libunwind/libcxx/libcxxabi with LLVM 5 and LLVM 4. Other runtime projects (compiler-rt, libcxx, libcxxabi) were modified to support the new "strip-and-install"

[PATCH] D38680: [libunwind] Fix handling of DW_CFA_GNU_args_size

2017-10-19 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Wow, I've finally debugged some unwind failures to this on x86_64 Linux ... 1. Call-frame optimization introduces it 2. This fixes the cases I was investigating!! Thank you! https://reviews.llvm.org/D38680 ___ cfe-commits

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

2017-07-13 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. In https://reviews.llvm.org/D34121#806978, @vsk wrote: > @dtzWill do you have any further comments on this one? > > I'd like to get another 'lgtm' before committing, and it'd be nice to get > this in before llvm 5.0 branches (7/19). > > FWIW we've been living on this for

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

2017-06-13 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. Don't mean to block this, but just FYI I won't be able to look into this carefully until later this week (sorry!). Kicked off a rebuild using these patches just now, though! O:) https://reviews.llvm.org/D34121 ___ cfe-comm

[PATCH] D33910: [ubsan] Detect invalid unsigned pointer index expression (clang)

2017-06-12 Thread Will Dietz via Phabricator via cfe-commits
dtzWill accepted this revision. dtzWill added a comment. LGTM! Sorry for missing this originally, as a perhaps interesting note: the checks were extracted from a research prototype that worked at the IR level --where pointer itself is unsigned but the offsets (including the computed total offse

[PATCH] D33305: [ubsan] Add a check for pointer overflow UB

2017-05-29 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. LGTM! I've built quite a bit with this (ground-up Linux distribution) which attests to it being fairly robust (no crashing or new errors not experienced with unpatched clang) and the bugs found so far are all true positives (few of which were caught and reported last t

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-24 Thread Will Dietz via Phabricator via cfe-commits
dtzWill accepted this revision. dtzWill added a comment. This revision is now accepted and ready to land. Sorry for the delay! LGTM, thanks! https://reviews.llvm.org/D29369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-14 Thread Will Dietz via Phabricator via cfe-commits
dtzWill added a comment. In https://reviews.llvm.org/D29369#673064, @vsk wrote: > In https://reviews.llvm.org/D29369#672166, @dtzWill wrote: > > > After some thought, can we discuss why this is a good idea? > > > The goal is to lower ubsan's compile-time + instrumentation overhead at -O0, > sinc

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-09 Thread Will Dietz via Phabricator via cfe-commits
dtzWill requested changes to this revision. dtzWill added a comment. This revision now requires changes to proceed. After some thought, can we discuss why this is a good idea? This increases the cyclomatic complexity of code that already is difficult to reason about, and seems like it's both bri

[PATCH] D29369: [ubsan] Omit superflous overflow checks for promoted arithmetic (PR20193)

2017-02-09 Thread Will Dietz via Phabricator via cfe-commits
dtzWill accepted this revision. dtzWill added a comment. I've been bitten when attempting to use existence/nature of casts in the AST to reason about the original code, but this looks like it does the right thing in all the situations I can think of. Missing overflows because of a bugged attemp