wxz2020 added a comment.
Thanks, Just sent Tom an email.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
wxz2020 added a comment.
I have a question here. Our customers need the TX3 support urgently, they asked
me to put this TX3 support to LLVM 10.0.1 and if there is 9.0.2 release
planned, they also need it there.
How can I do this? To put this checkin to LLVM 10.0.1 branch and 9.0.2 branch?
Is
wxz2020 added a comment.
Joel will help me to commit it. Thanks,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
___
cfe-commits mailing list
cfe-commits@lists.
wxz2020 updated this revision to Diff 263582.
wxz2020 added a comment.
Correct the wrong version of llvm/unittests/Support/TargetParserTest.cpp which
causes the test failure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews
wxz2020 updated this revision to Diff 263543.
wxz2020 added a comment.
1. in clang/test/Driver/aarch64-cpus.c, expanded the the same tests for
thunderx2t99 to thunderx3t110
2. in llvm/unittest/Support/TargetParserTest.cpp, fix the missing target
features
So far all the existing issues are fixed
wxz2020 updated this revision to Diff 263081.
wxz2020 added a comment.
fix a typo, thunderx3t110, not thunderx3t100 in TargetParserTest.cpp
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
Files:
llvm/include/llvm/Support/AArch64TargetParser.de
wxz2020 updated this revision to Diff 263079.
wxz2020 added a comment.
Fix the format issue in TargetParserTest.cpp
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
Files:
llvm/include/llvm/Support/AArch64
wxz2020 updated this revision to Diff 263070.
wxz2020 added a comment.
1. Added the predicates as suggested
2. brought back the TargetParserTest.cpp which was missed last time
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews
wxz2020 added a comment.
Sure I will add Joel's suggestion and other fixes later.
Thanks,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
___
cfe-commits maili
wxz2020 added a comment.
I think I made all the changes mentioned in the feedbacks. Please take sometime
to review the current version. We are eager to get the first thunderx3t110
checked in.
There are a few things we plan to do after the 1st version:
1. add more tests as suggested in the revi
wxz2020 updated this revision to Diff 262876.
wxz2020 added a comment.
Removed the PA related instructions from the .md file as suggested.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
Files:
llvm/inclu
wxz2020 added a comment.
I will put the "PAUnsupported" predicate later once this got passed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
___
cfe-commits ma
wxz2020 updated this revision to Diff 262665.
wxz2020 added a comment.
I put every people's feedbacks into the code and upload them here.
I think we can use it as the start point for TX3, and add more when we move on.
Thank you all for great help,
Repository:
rG LLVM Github Monorepo
CHANGES
wxz2020 added a comment.
I can confirm your findings, basically as long as we comment out the new
instructions, it will be OK to build.
Agree with your changes 1), 2) and 3).
4. this seems does not matter to build, as long as we comment out the new
instructions in 5), setting it "1" or "0", bo
wxz2020 marked an inline comment as done.
wxz2020 added a comment.
I tried to set CompleteModel = 0 on line 25 in file
llvm/lib/Target/AArch64/AArch64SchedThunderX3T110.td
The same error is still there.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857
+// These
wxz2020 updated this revision to Diff 261497.
wxz2020 marked an inline comment as done.
wxz2020 added a comment.
fixed all the feedback suggestions. Thanks,
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
F
wxz2020 marked 7 inline comments as done.
wxz2020 added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:89
CPU = llvm::sys::getHostCPUName();
-
if (CPU == "generic") {
DavidSpickett wrote:
> Remove stray change.
Removed
===
wxz2020 marked an inline comment as done.
wxz2020 added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857
+// These pointer authentication instructions require armv8.3a
+let Predicates = [HasV8_3a, HasPA] in {
let Uses = [LR], Defs = [LR] in {
d
wxz2020 updated this revision to Diff 260680.
wxz2020 added a comment.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Remove non-official target options. We now only support -mcpu=thunderx3t110
Typo fix.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
wxz2020 marked 2 inline comments as done.
wxz2020 added inline comments.
Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:849-857
+// These pointer authentication instructions require armv8.3a
+let Predicates = [HasV8_3a, HasPA] in {
let Uses = [LR], Defs = [LR] in {
d
wxz2020 added a comment.
Fix a format issue.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
wxz2020 updated this revision to Diff 259737.
wxz2020 added a comment.
fix a format issus.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
Files:
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
llvm/include/llvm/Support/AArch64TargetParser.def
wxz2020 updated this revision to Diff 259605.
wxz2020 added a comment.
Resubmit as the previous one was rejected by test plan changes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
https://reviews.llvm.org/D78129
Files:
clang/lib/Drive
wxz2020 updated this revision to Diff 257876.
wxz2020 added a comment.
The newly added two files were not accepted by the pre-merge check. Re worked
on the diff file and uploaded it now.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78129/new/
htt
wxz2020 created this revision.
wxz2020 added reviewers: joelkevinjones, pankajgode.
Herald added subscribers: cfe-commits, jfb, hiraditya.
Herald added a project: clang.
This is the first checkin to support Marvell ThunderX3T110.
Initial definition of the micro-ops of the instructions in ThunderX
25 matches
Mail list logo
